Bug 223523 - [GPUP] Add a "wallTime" field to struct RemoteMediaPlayerState
Summary: [GPUP] Add a "wallTime" field to struct RemoteMediaPlayerState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks: 221693
  Show dependency treegraph
 
Reported: 2021-03-19 10:23 PDT by Peng Liu
Modified: 2021-03-22 16:27 PDT (History)
13 users (show)

See Also:


Attachments
Patch (13.71 KB, patch)
2021-03-19 11:39 PDT, Peng Liu
no flags Details | Formatted Diff | Diff
Patch (13.70 KB, patch)
2021-03-19 11:42 PDT, Peng Liu
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix test failures and update TestExpectations (13.19 KB, patch)
2021-03-19 14:07 PDT, Peng Liu
eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (15.84 KB, patch)
2021-03-19 23:55 PDT, Peng Liu
no flags Details | Formatted Diff | Diff
Patch for landing - v2 (15.90 KB, patch)
2021-03-20 00:39 PDT, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-03-19 10:23:47 PDT
Add a “timestamp” field to struct RemoteMediaPlayerState
Comment 1 Peng Liu 2021-03-19 11:39:48 PDT
Created attachment 423755 [details]
Patch
Comment 2 Peng Liu 2021-03-19 11:42:17 PDT
Created attachment 423756 [details]
Patch
Comment 3 Peng Liu 2021-03-19 14:07:32 PDT
Created attachment 423774 [details]
Fix test failures and update TestExpectations
Comment 4 Eric Carlson 2021-03-19 14:50:06 PDT
Comment on attachment 423774 [details]
Fix test failures and update TestExpectations

View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814
> +    m_cachedState.timestamp = WallTime::now();

Nit: I think 'wallTime' might be more clear than 'timestamp'
Comment 5 Peng Liu 2021-03-19 14:54:45 PDT
Comment on attachment 423774 [details]
Fix test failures and update TestExpectations

View in context: https://bugs.webkit.org/attachment.cgi?id=423774&action=review

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:814
>> +    m_cachedState.timestamp = WallTime::now();
> 
> Nit: I think 'wallTime' might be more clear than 'timestamp'

Good idea! Will fix it after getting results from bots.
Comment 6 Peng Liu 2021-03-19 23:55:26 PDT
Created attachment 423805 [details]
Patch for landing

Revise the patch based on Eric's comment and fix a layout test failure in the previous version.
Comment 7 Peng Liu 2021-03-20 00:39:22 PDT
Created attachment 423806 [details]
Patch for landing - v2
Comment 8 EWS 2021-03-22 16:26:28 PDT
Committed r274816: <https://commits.webkit.org/r274816>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423806 [details].
Comment 9 Radar WebKit Bug Importer 2021-03-22 16:27:36 PDT
<rdar://problem/75714239>