Bug 223520 - [WebXR] Enumerate XR devices via ChromeClient in WebXRSystem
Summary: [WebXR] Enumerate XR devices via ChromeClient in WebXRSystem
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebXR (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-19 09:57 PDT by Ada Chan
Modified: 2021-03-22 17:07 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.90 KB, patch)
2021-03-19 09:59 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch (6.87 KB, patch)
2021-03-19 11:12 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2021-03-19 09:57:42 PDT 
[WebXR] Enumerate XR devices via ChromeClient in WebXRSystem
Comment 1 Ada Chan 2021-03-19 09:59:52 PDT 
Created attachment 423741 [details]
Patch
Comment 2 Sam Weinig 2021-03-19 10:34:38 PDT 
Comment on attachment 423741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423741&action=review

> Source/WebCore/ChangeLog:14
> +        * Modules/webxr/WebXRSystem.cpp:
> +        (WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected):
> +        * WebCore.xcodeproj/project.pbxproj:
> +        * page/ChromeClient.h:
> +        (WebCore::ChromeClient::enumerateImmersiveXRDevices):
> +        * platform/xr/PlatformXR.h:
> +

Ada, can you fill this out, including the rationale for this? Specifically, that we want to avoid singletons in the WebProcess and want to be able to proxy the devices from the UIProcess.
Comment 3 Ada Chan 2021-03-19 11:12:30 PDT 
Created attachment 423749 [details]
Patch
Comment 4 EWS 2021-03-22 17:05:34 PDT 
Committed r274821: <https://commits.webkit.org/r274821>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423749 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-22 17:07:10 PDT 
<rdar://problem/75715802>