RESOLVED FIXED 223518
[macOS] Context menu should account for image overlay content 
https://bugs.webkit.org/show_bug.cgi?id=223518
Summary [macOS] Context menu should account for image overlay content
Wenson Hsieh
Reported 2021-03-19 09:21:35 PDT
<rdar://problem/75505210>
Attachments
Patch (10.42 KB, patch)
2021-03-19 13:32 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (10.44 KB, patch)
2021-03-19 14:54 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-03-19 13:32:50 PDT
Created attachment 423767 [details] Patch
Devin Rousso
Comment 2 2021-03-19 13:46:49 PDT
Comment on attachment 423767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423767&action=review r=me > Source/WebCore/html/HTMLElement.cpp:1240 > + if (auto host = node.shadowHost(); is<HTMLElement>(host) && downcast<HTMLElement>(*host).hasImageOverlay()) > + return makeRefPtr(downcast<HTMLElement>(*host)); NIT: Can we avoid the double dereference-`downcast`?
Wenson Hsieh
Comment 3 2021-03-19 13:53:16 PDT
Comment on attachment 423767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423767&action=review >> Source/WebCore/html/HTMLElement.cpp:1240 >> + return makeRefPtr(downcast<HTMLElement>(*host)); > > NIT: Can we avoid the double dereference-`downcast`? Yes, fixed!
Wenson Hsieh
Comment 4 2021-03-19 14:54:12 PDT
Created attachment 423783 [details] Patch
EWS
Comment 5 2021-03-22 12:06:07 PDT
Committed r274772: <https://commits.webkit.org/r274772> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423783 [details].
Note You need to log in before you can comment on or make changes to this bug.