Bug 223483 - LiteralParser shouldn't make error messages of length ~2^31
Summary: LiteralParser shouldn't make error messages of length ~2^31
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-18 14:47 PDT by Saam Barati
Modified: 2021-03-22 16:01 PDT (History)
7 users (show)

See Also:

Attachments
patch (3.73 KB, patch)
2021-03-18 15:24 PDT, Saam Barati 		rmorisset: review+
Details | Formatted Diff | Diff
patch (3.76 KB, patch)
2021-03-18 18:10 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (3.76 KB, patch)
2021-03-18 18:12 PDT, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch for landing (4.44 KB, patch)
2021-03-22 12:16 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2021-03-18 14:47:21 PDT 
...
Comment 1 Saam Barati 2021-03-18 15:18:45 PDT 
<rdar://75572255>
Comment 2 Saam Barati 2021-03-18 15:24:59 PDT 
Created attachment 423663 [details]
patch
Comment 3 Robin Morisset 2021-03-18 15:27:28 PDT 
Comment on attachment 423663 [details]
patch

r=me
Comment 4 Saam Barati 2021-03-18 18:06:49 PDT 
The test failure doesn't reproduce for me locally ‼️
Comment 5 Saam Barati 2021-03-18 18:10:45 PDT 
Created attachment 423676 [details]
patch

try different form of test just to see
Comment 6 Saam Barati 2021-03-18 18:12:20 PDT 
Created attachment 423677 [details]
patch

this time without the syntax error
Comment 7 Saam Barati 2021-03-22 12:15:17 PDT 
(In reply to Saam Barati from comment #6)
> Created attachment 423677 [details]
> patch
> 
> this time without the syntax error

This is a different test, I just assumed it was the one I wrote 🤦‍♂️
Comment 8 Saam Barati 2021-03-22 12:16:15 PDT 
Created attachment 423917 [details]
patch for landing
Comment 9 EWS 2021-03-22 16:01:54 PDT 
Committed r274813: <https://commits.webkit.org/r274813>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423917 [details].