Bug 223482 - Crash under WebsiteDataStore::terminateNetworkProcess()
Summary: Crash under WebsiteDataStore::terminateNetworkProcess()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-18 14:41 PDT by Chris Dumez
Modified: 2021-03-18 16:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2021-03-18 14:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-18 14:41:41 PDT 
Crash under WebsiteDataStore::terminateNetworkProcess():
26 WebKit: WebKit::WebsiteDataStore::terminateNetworkProcess() <==
                        26 WebKit: WKWebsiteDataStoreTerminateNetworkProcess
                          26 WebKitTestRunner: WTR::TestController::terminateNetworkProcess()
                            26 WebKitTestRunner: WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*)
                              26 WebKitTestRunner: WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle(OpaqueWKString const*, void const*, OpaqueWKMessageListener const*)
                                26 WebKitTestRunner: WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener(OpaqueWKPage const*, OpaqueWKString const*, void const*, OpaqueWKMessageListener const*, void const*)
                                  26 WebKit: WebKit::WebPageInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle(WebKit::WebPageProxy*, WTF::String const&, API::Object*, WTF::CompletionHandler<void (WTF::RefPtr<API::Object, WTF::RawPtrTraits<API::Object>, WTF::DefaultRefDerefTraits<API::Object> >)>&&)
Comment 1 Chris Dumez 2021-03-18 14:41:59 PDT 
<rdar://75326967>
Comment 2 Chris Dumez 2021-03-18 14:58:08 PDT 
Created attachment 423662 [details]
Patch
Comment 3 Darin Adler 2021-03-18 14:59:29 PDT 
Comment on attachment 423662 [details]
Patch

RefPtr, not Ref?
Comment 4 Chris Dumez 2021-03-18 15:00:51 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 423662 [details]
> Patch
> 
> RefPtr, not Ref?

Because then I think I'd have to use WTF::map() and a lambda? Since my input container contains raw pointers. Would you prefer me to do that? It was a bit more code so I did not bother.
Comment 5 Darin Adler 2021-03-18 15:14:33 PDT 
(In reply to Chris Dumez from comment #4)
> Would you prefer me to do that?

No.
Comment 6 EWS 2021-03-18 16:22:05 PDT 
Committed r274683: <https://commits.webkit.org/r274683>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423662 [details].