Bug 223480 – Add a fast path for subdivideAndResolveStyle()

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

Add a fast path for subdivideAndResolveStyle()

[Simon Fraser (smfr)]

Created attachment 423661 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 423661 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423661&action=review

> Source/WebCore/ChangeLog:9
> +        Most of the time, InlineTextBox::paint() will be painting text runs with no marked text,
> +        so optimize subdivideAndResolveStyle() for this case.

Is the motivation cleanliness or performance? If performance, would be good to validate with a perf test.

> Source/WebCore/rendering/MarkedTextStyle.cpp:157
> +    if (textsToCoalesce.size() < 2)

nit: I think 1 is a more obvious sentinel than 2, so I would say "<= 1" instead of "< 2".

[Simon Fraser (smfr)]

Created attachment 423665 [details]
Patch

[Daniel Bates]

Looks good

[Daniel Bates]

Comment on attachment 423665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423665&action=review

> Source/WebCore/rendering/MarkedTextStyle.cpp:123
> +    Vector<StyledMarkedText> frontmostMarkedTexts;

Consider moving this back to avoid allocating inline storage.

[EWS]

Committed r274700: <https://commits.webkit.org/r274700>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423665 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75605441>