Bug 223478 - Address failing depth and stencil subcases in gl-object-get-calls
Summary: Address failing depth and stencil subcases in gl-object-get-calls
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on: 222964
Blocks: webgl2conformance
  Show dependency tree / graph
 
Reported: 2021-03-18 13:51 PDT by Kyle Piddington
Modified: 2022-08-11 02:35 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.75 KB, patch)
2021-03-18 13:56 PDT, Kyle Piddington 		kbr: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-03-18 13:51:12 PDT 
Address failing depth and stencil subcases in gl-object-get-calls
Comment 1 Kyle Piddington 2021-03-18 13:56:43 PDT 
Created attachment 423647 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-03-19 06:58:42 PDT 
Great!

I haven't checked what the spec says about these yet.

I'd like to defer to review this until I've landed the correct tests.

Kenneth might be able to review these on top of his head, though.
Comment 3 Kenneth Russell 2021-03-19 11:37:07 PDT 
Comment on attachment 423647 [details]
Patch

Good catches; these look correct. r+
Comment 4 Radar WebKit Bug Importer 2021-03-25 13:52:18 PDT 
<rdar://problem/75851597>
Comment 5 Kimmo Kinnunen 2022-08-11 02:35:26 PDT 
I think the bugs were fixed in bug 229947 and bug 242408 so the patch is not needed anymore.