Bug 223459 - Don't spend time painting transparent cell backgrounds
Summary: Don't spend time painting transparent cell backgrounds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-18 11:29 PDT by Simon Fraser (smfr)
Modified: 2021-03-18 16:23 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.95 KB, patch)
2021-03-18 11:31 PDT, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-03-18 11:29:49 PDT 
Don't spend time painting transparent cell backgrounds
Comment 1 Simon Fraser (smfr) 2021-03-18 11:31:03 PDT 
Created attachment 423622 [details]
Patch
Comment 2 Darin Adler 2021-03-18 15:26:33 PDT 
Comment on attachment 423622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review

> Source/WebCore/rendering/RenderTableCell.cpp:1287
> +    if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible()))

Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible.
Comment 3 Darin Adler 2021-03-18 15:27:07 PDT 
Comment on attachment 423622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review

>> Source/WebCore/rendering/RenderTableCell.cpp:1287
>> +    if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible()))
> 
> Typically we don’t also have to check isValid if we are checking isVisible, since the invalid color is also transparent block, and so guaranteed to be invisible.

transparent black
Comment 4 Simon Fraser (smfr) 2021-03-18 16:22:37 PDT 
https://trac.webkit.org/changeset/274682/webkit
Comment 5 Radar WebKit Bug Importer 2021-03-18 16:23:33 PDT 
<rdar://problem/75596249>