Bug 223446 – Handle empty bound size during animated resize

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sihui Liu]

...

[Sihui Liu]

Created attachment 423612 [details]
Patch

[Tim Horton]

Comment on attachment 423612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423612&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:254
> +    CGRect _validOldBounds;

Probably worth giving these names that make it clear they're just about (rare, SPI) animated resize; these names seem... more generic.

Maybe stick them up with _animatedResizeOriginalContentWidth?

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:-2910
> -    ASSERT_WITH_MESSAGE(!(_viewLayoutSizeOverride && newViewLayoutSize.isEmpty()), "Clients controlling the layout size should maintain a valid layout size to minimize layouts.");

Is there a reason we're not just fixing the clients? (and maybe making this louder?). Since it's SPI, it should be achievable, and it is wasted work otherwise.

[Sihui Liu]

Created attachment 423658 [details]
Patch

[Sihui Liu]

Created attachment 423671 [details]
Patch for landing

[EWS]

Committed r274692: <https://commits.webkit.org/r274692>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423671 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75598829>

[Geoffrey Garen]

> Is there a reason we're not just fixing the clients? (and maybe making this
> louder?). Since it's SPI, it should be achievable, and it is wasted work
> otherwise.

I think the answer -- based on ChangeLog and conversation with Sihui -- is that auto layout just sometimes does this (very temporarily), outside of direct client control.

Maybe this means we should file a Radar for auto layout.

[Tim Horton]

(In reply to Geoffrey Garen from comment #7)
> > Is there a reason we're not just fixing the clients? (and maybe making this
> > louder?). Since it's SPI, it should be achievable, and it is wasted work
> > otherwise.
> 
> I think the answer -- based on ChangeLog and conversation with Sihui -- is
> that auto layout just sometimes does this (very temporarily), outside of
> direct client control.
> 
> Maybe this means we should file a Radar for auto layout.

Yeah, she explained offline (and updated the changelog)! I do think we should make sure there is a radar, since it seems wasteful.