Implement RTCDataChannel transfer out of process
Created attachment 423595 [details] Patch
Created attachment 423600 [details] Patch
Created attachment 423621 [details] Patch
Comment on attachment 423621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423621&action=review > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73 > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > + if (Process::identifier() != localIdentifier.processIdentifier) > + return false; > + > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > + if (Process::identifier() != localIdentifier.processIdentifier) > + return false; This is included twice > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34 > +Â Â ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state); > +Â Â ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data); > +Â Â DetectError(struct WebCore::RTCDataChannelIdentifier handler); > +Â Â BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount); Are these tabs?
Created attachment 423864 [details] Patch for landing
Committed r274758: <https://commits.webkit.org/r274758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423864 [details].
<rdar://problem/75700538>
(In reply to Eric Carlson from comment #4) > Comment on attachment 423621 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423621&action=review > > > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73 > > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > > + if (Process::identifier() != localIdentifier.processIdentifier) > > + return false; > > + > > + ASSERT(Process::identifier() == localIdentifier.processIdentifier); > > + if (Process::identifier() != localIdentifier.processIdentifier) > > + return false; > > This is included twice Fixed > > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34 > > +Â Â ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state); > > +Â Â ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data); > > +Â Â DetectError(struct WebCore::RTCDataChannelIdentifier handler); > > +Â Â BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount); > > Are these tabs? Not sure, but I removed them, thanks!