Bug 223443 – Implement RTCDataChannel transfer out of process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Implement RTCDataChannel transfer out of process

[youenn fablet]

Created attachment 423595 [details]
Patch

[youenn fablet]

Created attachment 423600 [details]
Patch

[youenn fablet]

Created attachment 423621 [details]
Patch

[Eric Carlson]

Comment on attachment 423621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423621&action=review

> Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73
> +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> +    if (Process::identifier() != localIdentifier.processIdentifier)
> +        return false;
> +
> +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> +    if (Process::identifier() != localIdentifier.processIdentifier)
> +        return false;

This is included twice

> Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34
> +    ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state);
> +    ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data);
> +    DetectError(struct WebCore::RTCDataChannelIdentifier handler);
> +    BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount);

Are these tabs?

[youenn fablet]

Created attachment 423864 [details]
Patch for landing

[EWS]

Committed r274758: <https://commits.webkit.org/r274758>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423864 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75700538>

[youenn fablet]

(In reply to Eric Carlson from comment #4)
> Comment on attachment 423621 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423621&action=review
> 
> > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73
> > +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> > +    if (Process::identifier() != localIdentifier.processIdentifier)
> > +        return false;
> > +
> > +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> > +    if (Process::identifier() != localIdentifier.processIdentifier)
> > +        return false;
> 
> This is included twice

Fixed

> > Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in:34
> > +    ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler, enum:uint8_t WebCore::RTCDataChannelState state);
> > +    ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool isRaw, IPC::DataReference data);
> > +    DetectError(struct WebCore::RTCDataChannelIdentifier handler);
> > +    BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier handler, size_t amount);
> 
> Are these tabs?

Not sure, but I removed them, thanks!