RESOLVED FIXED223424
Update Keychain queries according to internal needs 
https://bugs.webkit.org/show_bug.cgi?id=223424
Summary Update Keychain queries according to internal needs
Jiewen Tan
Reported 2021-03-18 01:13:36 PDT
Update Keychain queries according to internal needs.
Attachments
Patch (9.37 KB, patch)
2021-03-18 01:18 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (9.46 KB, patch)
2021-03-18 16:18 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2021-03-18 01:13:49 PDT
rdar://75434045
Jiewen Tan
Comment 2 2021-03-18 01:18:00 PDT
Created attachment 423571 [details] Patch
Brent Fulgham
Comment 3 2021-03-18 12:47:51 PDT
Comment on attachment 423571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423571&action=review Can you try the simpler approach I suggested? > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:53 > +static void updateQuery(NSMutableDictionary *) This should probably be called ‘updateQueryIfNeeded’ > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 > - NSDictionary *query = @{ Could this just be NSMutableDictionary *query = @{ ... > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:188 > + [query setDictionary:@{ Ditto > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:397 > + auto query = adoptNS([[NSMutableDictionary alloc] init]); Ditto > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:603 > + [query setDictionary:@{ Ditto > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:673 > + [query setDictionary:@{ Ditto
Jiewen Tan
Comment 4 2021-03-18 14:23:51 PDT
Comment on attachment 423571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423571&action=review Thanks Brent for reviewing the patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:53 >> +static void updateQuery(NSMutableDictionary *) > > This should probably be called ‘updateQueryIfNeeded’ Good call! Let me change that. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 >> - NSDictionary *query = @{ > > Could this just be NSMutableDictionary *query = @{ ... I don't think this could work.
Brent Fulgham
Comment 5 2021-03-18 15:46:45 PDT
Comment on attachment 423571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423571&action=review >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 >>> - NSDictionary *query = @{ >> >> Could this just be NSMutableDictionary *query = @{ ... > > I don't think this could work. auto query = [NSMutableDictionary dictionaryWithObjectsAndKeys: @"value1", @"key1", @"value2", @"key2", nil];
Jiewen Tan
Comment 6 2021-03-18 15:54:42 PDT
(In reply to Brent Fulgham from comment #5) > Comment on attachment 423571 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423571&action=review > > >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 > >>> - NSDictionary *query = @{ > >> > >> Could this just be NSMutableDictionary *query = @{ ... > > > > I don't think this could work. > > auto query = [NSMutableDictionary dictionaryWithObjectsAndKeys: > @"value1", @"key1", @"value2", @"key2", nil]; Thanks Brent for r+ this patch.
Jiewen Tan
Comment 7 2021-03-18 16:18:00 PDT
Created attachment 423667 [details] Patch
EWS
Comment 8 2021-03-18 16:46:27 PDT
Committed r274689: <https://commits.webkit.org/r274689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423667 [details].
Note You need to log in before you can comment on or make changes to this bug.