Update Keychain queries according to internal needs.
rdar://75434045
Created attachment 423571 [details] Patch
Comment on attachment 423571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423571&action=review Can you try the simpler approach I suggested? > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:53 > +static void updateQuery(NSMutableDictionary *) This should probably be called ‘updateQueryIfNeeded’ > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 > - NSDictionary *query = @{ Could this just be NSMutableDictionary *query = @{ ... > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:188 > + [query setDictionary:@{ Ditto > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:397 > + auto query = adoptNS([[NSMutableDictionary alloc] init]); Ditto > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:603 > + [query setDictionary:@{ Ditto > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:673 > + [query setDictionary:@{ Ditto
Comment on attachment 423571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423571&action=review Thanks Brent for reviewing the patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:53 >> +static void updateQuery(NSMutableDictionary *) > > This should probably be called ‘updateQueryIfNeeded’ Good call! Let me change that. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 >> - NSDictionary *query = @{ > > Could this just be NSMutableDictionary *query = @{ ... I don't think this could work.
Comment on attachment 423571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423571&action=review >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 >>> - NSDictionary *query = @{ >> >> Could this just be NSMutableDictionary *query = @{ ... > > I don't think this could work. auto query = [NSMutableDictionary dictionaryWithObjectsAndKeys: @"value1", @"key1", @"value2", @"key2", nil];
(In reply to Brent Fulgham from comment #5) > Comment on attachment 423571 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423571&action=review > > >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:-132 > >>> - NSDictionary *query = @{ > >> > >> Could this just be NSMutableDictionary *query = @{ ... > > > > I don't think this could work. > > auto query = [NSMutableDictionary dictionaryWithObjectsAndKeys: > @"value1", @"key1", @"value2", @"key2", nil]; Thanks Brent for r+ this patch.
Created attachment 423667 [details] Patch
Committed r274689: <https://commits.webkit.org/r274689> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423667 [details].