Bug 223422 - CSP headers can block default <video> controls
Summary: CSP headers can block default <video> controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
: 191782 225865 (view as bug list)
Depends on: 223487
Blocks:
  Show dependency treegraph
 
Reported: 2021-03-18 00:52 PDT by Devin Rousso
Modified: 2023-08-27 23:36 PDT (History)
20 users (show)

See Also:


Attachments
Patch (2.76 KB, patch)
2021-03-18 01:00 PDT, Devin Rousso
graouts: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2021-03-18 11:15 PDT, Devin Rousso
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.59 KB, patch)
2021-03-18 20:09 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-18 00:52:27 PDT
.
Comment 1 Devin Rousso 2021-03-18 00:52:39 PDT
<rdar://problem/41192193>
Comment 2 Devin Rousso 2021-03-18 01:00:37 PDT
Created attachment 423569 [details]
Patch
Comment 3 EWS 2021-03-18 03:08:02 PDT Comment hidden (obsolete)
Comment 4 Devin Rousso 2021-03-18 11:15:07 PDT
Created attachment 423620 [details]
Patch

I'm pretty sure the test failures were due to not having r274625 yet 🤔
Comment 5 EWS 2021-03-18 13:26:40 PDT
Committed r274669: <https://commits.webkit.org/r274669>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423620 [details].
Comment 6 Aakash Jain 2021-03-18 15:55:10 PDT
(In reply to Devin Rousso from comment #4)
> I'm pretty sure the test failures were due to not having r274625 yet 🤔

https://ews-build.webkit.org/#/builders/56/builds/3789 used 235479@main (displayed in step 6) which is r274654.
https://ews-build.webkit.org/#/builders/60/builds/131 used 235476@main which is r274651

r274654 and r274651 are after r274625. Please check.

Also These tests are now crashing on post-commit bots too, e.g.: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fresource-initiatorNode.html&test=http%2Ftests%2Finspector%2Fdom%2FdidFireEvent.html
Comment 7 WebKit Commit Bot 2021-03-18 16:37:54 PDT
Re-opened since this is blocked by bug 223487
Comment 8 Devin Rousso 2021-03-18 20:09:47 PDT
Created attachment 423685 [details]
Patch
Comment 9 EWS 2021-03-19 07:35:06 PDT
Committed r274717: <https://commits.webkit.org/r274717>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423685 [details].
Comment 10 Sam Sneddon [:gsnedders] 2022-02-14 19:06:11 PST
*** Bug 191782 has been marked as a duplicate of this bug. ***
Comment 11 Anne van Kesteren 2023-08-27 23:36:47 PDT
*** Bug 225865 has been marked as a duplicate of this bug. ***