Bug 223421 - should always use all prerequisites for the `ModernMediaControls.{js,css}` rules in DerivedSources.make
Summary: should always use all prerequisites for the `ModernMediaControls.{js,css}` ru...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 223309 223410
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-18 00:51 PDT by Devin Rousso
Modified: 2021-03-18 02:12 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2021-03-18 00:51 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2021-03-18 00:53 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-18 00:51:05 PDT 
`$?` is a uniqued space-separated list of all prerequisites modified after the target was modified
`$^` is a uniqued space-separated list of all prerequisites regardless of when the target/prerequisite was modified
We want to use the latter since we always want to `cat` all the JS/CSS files, not just the recently edited ones.
Comment 1 Devin Rousso 2021-03-18 00:51:34 PDT 
Created attachment 423566 [details]
Patch
Comment 2 Devin Rousso 2021-03-18 00:53:28 PDT 
Created attachment 423567 [details]
Patch
Comment 3 Yusuke Suzuki 2021-03-18 00:57:42 PDT 
Comment on attachment 423567 [details]
Patch

Nice, r=me
Comment 4 EWS 2021-03-18 02:11:17 PDT 
Committed r274625: <https://commits.webkit.org/r274625>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423567 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-18 02:12:15 PDT 
<rdar://problem/75565469>