RESOLVED FIXED223398
Reduce maximum HashTable entry size to 250 bytes 
https://bugs.webkit.org/show_bug.cgi?id=223398
Summary Reduce maximum HashTable entry size to 250 bytes
Alex Christensen
Reported 2021-03-17 13:40:03 PDT
Reduce maximum HashTable entry size to 250 bytes
Attachments
Patch (15.54 KB, patch)
2021-03-17 13:41 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-03-17 13:41:10 PDT
Created attachment 423524 [details] Patch
Yusuke Suzuki
Comment 2 2021-03-17 16:35:55 PDT
Comment on attachment 423524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423524&action=review r=me > Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:74 > + trackBuffer.get().lastFrameTimescale = 0; > + trackBuffer.get().roundedTimestampOffset = MediaTime::invalidTime(); Why not using `->`?
Alex Christensen
Comment 3 2021-03-17 16:45:06 PDT
Comment on attachment 423524 [details] Patch They are equivalent but -> looks the same as dereferencing an unchecked pointer if the type were different. This makes it clearer that null check is needed.
EWS
Comment 4 2021-03-17 17:16:01 PDT
Committed r274603: <https://commits.webkit.org/r274603> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423524 [details].
Radar WebKit Bug Importer
Comment 5 2021-03-17 17:17:15 PDT
<rdar://problem/75551716>
Note You need to log in before you can comment on or make changes to this bug.