Bug 223398 - Reduce maximum HashTable entry size to 250 bytes
Summary: Reduce maximum HashTable entry size to 250 bytes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-17 13:40 PDT by Alex Christensen
Modified: 2021-03-17 17:17 PDT (History)
6 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2021-03-17 13:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-03-17 13:40:03 PDT 
Reduce maximum HashTable entry size to 250 bytes
Comment 1 Alex Christensen 2021-03-17 13:41:10 PDT 
Created attachment 423524 [details]
Patch
Comment 2 Yusuke Suzuki 2021-03-17 16:35:55 PDT 
Comment on attachment 423524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423524&action=review

r=me

> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:74
> +        trackBuffer.get().lastFrameTimescale = 0;
> +        trackBuffer.get().roundedTimestampOffset = MediaTime::invalidTime();

Why not using `->`?
Comment 3 Alex Christensen 2021-03-17 16:45:06 PDT 
Comment on attachment 423524 [details]
Patch

They are equivalent but -> looks the same as dereferencing an unchecked pointer if the type were different.  This makes it clearer that null check is needed.
Comment 4 EWS 2021-03-17 17:16:01 PDT 
Committed r274603: <https://commits.webkit.org/r274603>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423524 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-17 17:17:15 PDT 
<rdar://problem/75551716>