Bug 223397 - [webkitscmpy] Support git-svn in remote mocks
Summary: [webkitscmpy] Support git-svn in remote mocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-17 13:37 PDT by Jonathan Bedard
Modified: 2021-03-26 11:45 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.76 KB, patch)
2021-03-17 13:40 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-03-17 13:37:05 PDT 
We should be able to add git-svn tags in BitBucket and GitHub remote mock structures.
Comment 1 Radar WebKit Bug Importer 2021-03-17 13:37:18 PDT 
<rdar://problem/75541426>
Comment 2 Jonathan Bedard 2021-03-17 13:37:28 PDT 
Thought we had this already, apparently we do not.
Comment 3 Jonathan Bedard 2021-03-17 13:40:48 PDT 
Created attachment 423523 [details]
Patch
Comment 4 Jonathan Bedard 2021-03-17 13:47:24 PDT 
Committed r274587 (235428@main): <https://commits.webkit.org/235428@main>
Comment 5 Aakash Jain 2021-03-18 05:21:38 PDT 
(In reply to Jonathan Bedard from comment #4)
> Committed r274587 (235428@main): <https://commits.webkit.org/235428@main>
Seems like it broke resultsdbpy-unit-tests, e.g.: https://ews-build.webkit.org/#/builders/20/builds/42930/steps/14/logs/stdio
Comment 6 Jonathan Bedard 2021-03-22 08:23:49 PDT 
(In reply to Aakash Jain from comment #5)
> (In reply to Jonathan Bedard from comment #4)
> > Committed r274587 (235428@main): <https://commits.webkit.org/235428@main>
> Seems like it broke resultsdbpy-unit-tests, e.g.:
> https://ews-build.webkit.org/#/builders/20/builds/42930/steps/14/logs/stdio

Yes, https://bugs.webkit.org/show_bug.cgi?id=223261 fixes that (although does many other things as well)
Comment 7 Aakash Jain 2021-03-26 11:45:03 PDT 
(In reply to Jonathan Bedard from comment #6)
> (In reply to Aakash Jain from comment #5)
> > (In reply to Jonathan Bedard from comment #4)
> > > Committed r274587 (235428@main): <https://commits.webkit.org/235428@main>
> > Seems like it broke resultsdbpy-unit-tests, e.g.:
> > https://ews-build.webkit.org/#/builders/20/builds/42930/steps/14/logs/stdio
> 
> Yes, https://bugs.webkit.org/show_bug.cgi?id=223261 fixes that (although
> does many other things as well)
Can we fix the tests in a separate bug and land it soon.