Bug 223396 – Web Inspector: Port grid overlay drawing to iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

<rdar://75333290>

[Patrick Angle]

Created attachment 423782 [details]
Patch v1.0

[Patrick Angle]

Created attachment 423788 [details]
Patch v1.1 - Add FloatLine.h to Headers.cmake

[Sam Weinig]

Comment on attachment 423788 [details]
Patch v1.1 - Add FloatLine.h to Headers.cmake

View in context: https://bugs.webkit.org/attachment.cgi?id=423788&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.h:500
> +template<> struct ArgumentCoder<WebCore::InspectorOverlay::Highlight::GridHighlightOverlay> {
> +    static void encode(Encoder&, const WebCore::InspectorOverlay::Highlight::GridHighlightOverlay&);
> +    static WARN_UNUSED_RETURN bool decode(Decoder&, WebCore::InspectorOverlay::Highlight::GridHighlightOverlay&);
> +};
> +
> +template<> struct ArgumentCoder<WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label> {
> +    static void encode(Encoder&, const WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label&);
> +    static WARN_UNUSED_RETURN bool decode(Decoder&, WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Label&);
> +};
> +
> +template<> struct ArgumentCoder<WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Area> {
> +    static void encode(Encoder&, const WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Area&);
> +    static WARN_UNUSED_RETURN bool decode(Decoder&, WebCore::InspectorOverlay::Highlight::GridHighlightOverlay::Area&);
> +};

Rather than adding new coders here (which we are tying to avoid), please instead add the coders to the files these types are defined in using the generic coding (e.g. template<class Encoder>/template<class Decoder>) pattern.

[Patrick Angle]

Comment on attachment 423788 [details]
Patch v1.1 - Add FloatLine.h to Headers.cmake

View in context: https://bugs.webkit.org/attachment.cgi?id=423788&action=review

>> Source/WebKit/Shared/WebCoreArgumentCoders.h:500
>> +};
> 
> Rather than adding new coders here (which we are tying to avoid), please instead add the coders to the files these types are defined in using the generic coding (e.g. template<class Encoder>/template<class Decoder>) pattern.

👍🏻

[Patrick Angle]

Created attachment 423842 [details]
Patch v1.2 - Move new encoders/decoders to InspectorOverlay.h

[Blaze Burg]

Comment on attachment 423842 [details]
Patch v1.2 - Move new encoders/decoders to InspectorOverlay.h

r=me

It's now possible to test the intermediate results of the grid overlay algorithm (HighlightConfig). If you can think of an area of this code that is likely to break, we can write a test for it. This would require helpers to dump the highlight data from WebCore Internals.

[EWS]

Committed r274822: <https://commits.webkit.org/r274822>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423842 [details].