Bug 223388 – Determine if we have useFastJITPermissions on arm64e at runtime instead of hardcoding it as always enabled

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

<rdar://74819266>

[Saam Barati]

Created attachment 423509 [details]
patch

[Saam Barati]

Created attachment 423510 [details]
patch

[Mark Lam]

Comment on attachment 423510 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423510&action=review

r=me with suggested improvement.

> Source/WTF/wtf/PlatformEnableCocoa.h:477
> +#if !defined(ENABLE_SEPARATED_WX_HEAP) && CPU(ARM64)
>  #define ENABLE_SEPARATED_WX_HEAP 1

We used to not build in the code for initializeSeparatedWXHeaps() and jitWriteThunkGenerator() at all on ARM64E.  Now, we do.  Can you add the following to those 2 functions as a sanity check:

    auto exitScope = makeScopeExit([] {
        RELEASE_ASSERT(!g_jscConfig.useFastJITPermissions);
    });

[Saam Barati]

(In reply to Mark Lam from comment #4)
> Comment on attachment 423510 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423510&action=review
> 
> r=me with suggested improvement.
> 
> > Source/WTF/wtf/PlatformEnableCocoa.h:477
> > +#if !defined(ENABLE_SEPARATED_WX_HEAP) && CPU(ARM64)
> >  #define ENABLE_SEPARATED_WX_HEAP 1
> 
> We used to not build in the code for initializeSeparatedWXHeaps() and
> jitWriteThunkGenerator() at all on ARM64E.  Now, we do.  Can you add the
> following to those 2 functions as a sanity check:
> 
>     auto exitScope = makeScopeExit([] {
>         RELEASE_ASSERT(!g_jscConfig.useFastJITPermissions);
>     });

Sounds good.

[Saam Barati]

Created attachment 423531 [details]
patch for landing

[EWS]

Committed r274602: <https://commits.webkit.org/r274602>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423531 [details].