Bug 223340 – [GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GTK][WPE][CMake] libCMS2 should be included only if guard USE_LCMS is defined

[Diego Pino]

Created attachment 423443 [details]
Patch

[Carlos Garcia Campos]

Why? aren't those just empty?

[Diego Pino]

(In reply to Carlos Garcia Campos from comment #2)
> Why? aren't those just empty?

In the webkitsearch instance I build WebKit directly using cmake, with a command like this:

cmake /home/buildbot/webkit-index/webkit/WebKit -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ '-DCMAKE_C_FLAGS=-Xclang -load -Xclang /home/buildbot/mozsearch/clang-plugin/libclang-index-plugin.so -Xclang -add-plugin -Xclang mozsearch-index -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/analysis -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit/target -Xclang -fparse-all-comments' '-DCMAKE_CXX_FLAGS=-Xclang -load -Xclang /home/buildbot/mozsearch/clang-plugin/libclang-index-plugin.so -Xclang -add-plugin -Xclang mozsearch-index -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/analysis -Xclang -plugin-arg-mozsearch-index -Xclang /home/buildbot/webkit-index/webkit/WebKit/target -Xclang -fparse-all-comments' -DUSE_WPE_RENDERER=OFF -DUSE_LCMS=OFF -DENABLE_BUBBLEWRAP_SANDBOX=OFF -DENABLE_GAMEPAD=OFF -DCMAKE_BUILD_TYPE=Debug -DPORT=GTK

I got the following error when passing -DUSE_LCMS=OFF:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
LCMS2_INCLUDE_DIR (ADVANCED)
   used as include directory in directory /home/buildbot/webkit-index/webkit/WebKit/Source/WebCore
...
LCMS2_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/buildbot/webkit-index/webkit/WebKit/Source/WebCore
...

[EWS]

Committed r274685: <https://commits.webkit.org/r274685>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423443 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75596979>