Bug 22332 - malformed interfaces in WebCore idls
Summary: malformed interfaces in WebCore idls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows Vista
: P5 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-18 01:42 PST by Nathan Howell
Modified: 2011-05-16 19:31 PDT (History)
3 users (show)

See Also:

Attachments
Proposed fix (1.06 KB, patch)
2008-11-18 01:43 PST, Nathan Howell 		sam: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Howell 2008-11-18 01:42:49 PST 
found these two inconsistent interfaces while developing a grammar to parse  .idls.

WebCore/svg/SVGSVGElement.idl: "setter raises" used on a method instead of "raises"
WebCore/css/WebKitCSSTransformValue.idl: HasIndexGetter extended attribute is missing a comma
Comment 1 Nathan Howell 2008-11-18 01:43:48 PST 
Created attachment 25232 [details]
Proposed fix
Comment 2 Sam Weinig 2008-11-18 09:50:16 PST 
Comment on attachment 25232 [details]
Proposed fix

This needs a ChangeLog, but otherwise looks good.

r- for the ChangeLog.
Comment 3 Alexey Proskuryakov 2008-11-19 05:04:08 PST 
Does the WebKitCSSTransformValue problem cause a real bug? IIRC missing spaces are not ignored there, so the fix should correct actual behavior.
Comment 4 Cameron McCormack (:heycam) 2009-09-04 02:41:49 PDT 
The "setter raises" part of this was fixed with http://trac.webkit.org/changeset/47890.
Comment 5 Rob Buis 2011-05-16 19:02:17 PDT 
The HasIndexGetter part is also fixed nowadays, so I think we can close this.
Cheers,

Rob.