...
<rdar://problem/75508598>
Created attachment 423429 [details] Patch
Created attachment 423490 [details] Patch
Comment on attachment 423490 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423490&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1456 > + if (cssValueID == CSSValueAppleSystemSecondaryFillDisabled) > + return systemColor(CSSValueAppleSystemSecondaryFill, options).colorWithAlphaMultipliedBy(0.75f); Why are we synthesizing not-real semantic colors instead of just doing it in content? > Source/WebCore/rendering/RenderThemeIOS.mm:2159 > + // The inner circle is 1 / 3 the size of the surrounding circle, > + // leaving 2 / 3 around it. (2 / 3) / 2 = 1 / 3. > + constexpr float innerInverseRatio = 1 / 3.0f; What's this got to do with system colors?
(In reply to Tim Horton from comment #4) > Comment on attachment 423490 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=423490&action=review > > > Source/WebCore/rendering/RenderThemeIOS.mm:1456 > > + if (cssValueID == CSSValueAppleSystemSecondaryFillDisabled) > > + return systemColor(CSSValueAppleSystemSecondaryFill, options).colorWithAlphaMultipliedBy(0.75f); > > Why are we synthesizing not-real semantic colors instead of just doing it in > content? UIKit doesn't expose this color for us to use, but it's the color for disabled buttons. I'll make a request and add a FIXME. > > Source/WebCore/rendering/RenderThemeIOS.mm:2159 > > + // The inner circle is 1 / 3 the size of the surrounding circle, > > + // leaving 2 / 3 around it. (2 / 3) / 2 = 1 / 3. > > + constexpr float innerInverseRatio = 1 / 3.0f; > > What's this got to do with system colors? This is a change we need to make to radio buttons, but I'll move it into a separate patch.
Created attachment 423516 [details] Patch for landing
Committed r274600: <https://commits.webkit.org/r274600> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423516 [details].