Bug 223298 - Only send image across XPC to GPU process if it changes.
Summary: Only send image across XPC to GPU process if it changes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on: 223435
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-16 19:33 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-03-23 09:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.68 KB, patch)
2021-03-21 20:24 PDT, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2021-03-21 20:25 PDT, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-03-16 19:33:38 PDT 
As in bug 223118 comment 17; we want to only send the image to the GPU process when the image actually changed to avoid unnecessary overhead.

We could deal with the check in the MediaSessionManagerCocoa so that the implementation details are removed from MediaElementSession.
Comment 1 Radar WebKit Bug Importer 2021-03-17 21:34:29 PDT 
<rdar://problem/75559236>
Comment 2 Jean-Yves Avenard [:jya] 2021-03-21 20:24:38 PDT 
Created attachment 423846 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-03-21 20:25:56 PDT 
Created attachment 423847 [details]
Patch
Comment 4 Jean-Yves Avenard [:jya] 2021-03-23 06:01:25 PDT 
EWS failure (crash) doesn't appear to hit the code path touched by this change.
Comment 5 Eric Carlson 2021-03-23 08:47:49 PDT 
Comment on attachment 423847 [details]
Patch

r=me once the bots are happy
Comment 6 EWS 2021-03-23 09:18:31 PDT 
Committed r274873: <https://commits.webkit.org/r274873>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423847 [details].