Bug 22329 - Improper bitwise and tests against 0 in Windows context menu code
Summary: Improper bitwise and tests against 0 in Windows context menu code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Steve Falkenburg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-17 22:33 PST by Steve Falkenburg
Modified: 2008-11-18 11:50 PST (History)
0 users

See Also:

Attachments
Fix bitwise ands against 0 (1.53 KB, patch)
2008-11-17 22:40 PST, Steve Falkenburg 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2008-11-17 22:33:36 PST 
Microsoft's PREfast static code analysis flagged:

c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(106) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags
c:\cygwin\home\safari user\webkit\opensource\webcore\platform\win\contextmenuitemwin.cpp(190) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags
Comment 1 Steve Falkenburg 2008-11-17 22:40:17 PST 
Created attachment 25231 [details]
Fix bitwise ands against 0
Comment 2 Steve Falkenburg 2008-11-18 11:50:07 PST 
Fixed in r38565