Bug 223282 - REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timing out
Summary: REGRESSION (r274460): [macOS] TestWebKitAPI.Fullscreen.WKViewDelegate is timi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
: 225802 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-16 14:49 PDT by Amir Mark Jr
Modified: 2021-05-30 04:43 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2021-05-14 04:06 PDT, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2021-05-27 22:11 PDT, Jean-Yves Avenard [:jya] 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2021-05-27 23:01 PDT, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Amir Mark Jr 2021-03-16 14:49:05 PDT 
TestWebKitAPI.Fullscreen.WKViewDelegate is timing out on Catalina, Big Sur and Big Sur Apple Silicon 

https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.WKViewDelegate

https://build.webkit.org/#/builders/48/builds/1076/steps/11/logs/stdio
Comment 1 Radar WebKit Bug Importer 2021-03-16 14:49:27 PDT 
<rdar://problem/75495585>
Comment 2 Amir Mark Jr 2021-03-16 15:10:32 PDT 
Regression point related to: https://trac.webkit.org/changeset/274460/webkit
Comment 3 Ryan Haddad 2021-03-17 09:40:52 PDT 
Jer is going to look at this today. We will disable the test for now.
Comment 4 Amir Mark Jr 2021-03-17 11:22:42 PDT 
Disabled API test:

https://trac.webkit.org/changeset/274572/webkit
Comment 5 Jean-Yves Avenard [:jya] 2021-05-14 04:06:58 PDT 
Created attachment 428616 [details]
Patch
Comment 6 Jean-Yves Avenard [:jya] 2021-05-14 04:08:13 PDT 
*** Bug 225802 has been marked as a duplicate of this bug. ***
Comment 7 EWS 2021-05-14 15:18:14 PDT 
Committed r277508 (237739@main): <https://commits.webkit.org/237739@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428616 [details].
Comment 8 Truitt Savell 2021-05-21 10:44:43 PDT 
This test is still timing out now that is has been reenabled:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.Fullscreen.WKViewDelegate
Comment 9 Jean-Yves Avenard [:jya] 2021-05-27 22:11:57 PDT 
Created attachment 429984 [details]
Patch
Comment 10 Jean-Yves Avenard [:jya] 2021-05-27 23:01:22 PDT 
Created attachment 429990 [details]
Patch

Removed no longer used method
Comment 11 Darin Adler 2021-05-29 22:46:17 PDT 
We could do one better by removing the underlying feature entirely so no one can use it even by accident.
Comment 12 EWS 2021-05-30 04:43:56 PDT 
Committed r278252 (238289@main): <https://commits.webkit.org/238289@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429990 [details].