Bug 223260 - ANGLE Metal fixups for program generation, readPixels
Summary: ANGLE Metal fixups for program generation, readPixels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 222239
Blocks:
  Show dependency tree / graph
 
Reported: 2021-03-16 10:17 PDT by Kyle Piddington
Modified: 2021-03-17 13:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.26 KB, patch)
2021-03-16 10:44 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2021-03-17 10:43 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Patch (9.46 KB, patch)
2021-03-17 10:50 PDT, Kyle Piddington 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-03-16 10:17:03 PDT 
ANGLE Metal fixups for program generation
Comment 1 Kyle Piddington 2021-03-16 10:44:16 PDT 
Created attachment 423353 [details]
Patch
Comment 2 EWS Watchlist 2021-03-16 10:45:20 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kyle Piddington 2021-03-16 10:48:57 PDT 
2021-03-16  Kyle Piddington  <kpiddington@apple.com>

        ANGLE Metal fixups for program generation, readPixels
        https://bugs.webkit.org/show_bug.cgi?id=223260
       This diff fixes the following tests:
               webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate.html Is fixed by dropping 'thread' qualifiers on our intermediate texture sampling helper functions. Previously, any uniforms used in sampling textures would have had issues with their namespace.
               webgl/2.0.0/conformance2/reading/read-pixels-pack-parameters.html is fixed by correcting an issue with reading from outside the framebuffer. ANGLE Metal was previously reading to the start of the output array, rather than a proper offset.
                webgl/2.0.0/conformance2/glsl3/array-equality.html is fixed by adding additional equality functions for handling arrays of structs.

        Reviewed by NOBODY (OOPS!).

        * src/compiler/translator/TranslatorMetalDirect/EmitMetal.cpp:
        (GetOperatorString):
        * src/compiler/translator/TranslatorMetalDirect/ProgramPrelude.cpp:
        * src/libANGLE/renderer/metal/FrameBufferMtl.mm:
        (rx::FramebufferMtl::readPixels):
Comment 4 Dean Jackson 2021-03-16 14:54:38 PDT 
Comment on attachment 423353 [details]
Patch

You're missing a changelog.
Comment 5 Kyle Piddington 2021-03-17 10:43:00 PDT 
Created attachment 423501 [details]
Patch
Comment 6 Kyle Piddington 2021-03-17 10:50:54 PDT 
Created attachment 423502 [details]
Patch
Comment 7 Dean Jackson 2021-03-17 13:44:42 PDT 
Committed r274585 (235426@main): <https://commits.webkit.org/235426@main>
Comment 8 Radar WebKit Bug Importer 2021-03-17 13:45:22 PDT 
<rdar://problem/75541805>