Apply permission policy to geolocation
Created attachment 423316 [details]
Created attachment 423328 [details]
Comment on attachment 423328 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=423328&action=review
> + if (!isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Geolocation, *document(), LogFeaturePolicyFailure::Yes))
> + return true;
As we discussed, I think a linked-on-or-after check would be a good idea so we don't break existing apps that depend on the old behavior.
> As we discussed, I think a linked-on-or-after check would be a good idea so
> we don't break existing apps that depend on the old behavior.
If we add a linked-on-or-after check here, we probably need to do the same when computing the origin shown on the geolocation prompt.
We can probably do that, but maybe we can try to land this change and use linked-on-or-after if we see breakage?
Tools/Scripts/svn-apply failed to apply attachment 423328 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 424637 [details]
Patch for landing
Committed r275276: <https://commits.webkit.org/r275276>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 424637 [details].