Bug 223235 - [git-webkit] Showing help instead of raising an exception with no command
Summary: [git-webkit] Showing help instead of raising an exception with no command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 20:46 PDT by Ryosuke Niwa
Modified: 2021-03-16 13:51 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.52 KB, patch)
2021-03-16 09:50 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-03-15 20:46:45 PDT
Instead of raising an exception, show the help when there is no command specified. 
% ./Tools/Scripts/git-webkit       
Traceback (most recent call last):
  File "./Tools/Scripts/git-webkit", line 45, in <module>
    sys.exit(program.main(
  File "./Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py", line 76, in main
    return parsed.main(
AttributeError: 'Namespace' object has no attribute 'main'
Comment 1 Radar WebKit Bug Importer 2021-03-16 09:47:27 PDT
<rdar://problem/75480951>
Comment 2 Jonathan Bedard 2021-03-16 09:47:42 PDT
Just an overbite that this isn't the case now.
Comment 3 Jonathan Bedard 2021-03-16 09:50:27 PDT
Created attachment 423343 [details]
Patch
Comment 4 Jonathan Bedard 2021-03-16 10:01:32 PDT
(In reply to Jonathan Bedard from comment #2)
> Just an overbite that this isn't the case now.

*oversite
Comment 5 EWS 2021-03-16 13:51:14 PDT
Committed r274512: <https://commits.webkit.org/r274512>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423343 [details].