NEW 22323
Enable pixel tests by default on Mac 
https://bugs.webkit.org/show_bug.cgi?id=22323
Summary Enable pixel tests by default on Mac
Pierre-Olivier Latour
Reported 2008-11-17 14:01:23 PST
Following a discussion on IRC, we should figure out if we want to enable pixel tests by default on Mac
Attachments
Add attachment proposed patch, testcase, etc.
Pierre-Olivier Latour
Comment 1 2008-11-17 14:04:31 PST
First of all, it would be for Mac and OS X Leopard only for now: - on other platforms, pixel tests aren't really supported - on Tiger, too many images slightly differ (because of very minor differences in font rendering), which makes the fast hash comparison fail, and require ImageDiff to run and slows down everything
Pierre-Olivier Latour
Comment 2 2008-11-18 10:56:32 PST
r38525 build debug on iMac Intel w/ 10.5.4: - /LayoutTests w/ pixel tests disabled: 474.57s - /LayoutTests w/ pixel tests enabled: 561.61s (+18.3%) - /LayoutTests/fast w/ pixel tests disabled: 140.98s - /LayoutTests/fast w/ pixel tests enabled: 157.22s (+11.5%)
Pierre-Olivier Latour
Comment 3 2008-11-18 11:46:04 PST
Second run on /LayoutTests:using the same configuration: - pixel tests disabled: 497.92s = pixel tests enabled: 565.44s (+13.5%)
Pierre-Olivier Latour
Comment 4 2008-11-19 13:33:03 PST
Some other stats using r38600 Release on a Mac Book Pro with 10.5.4: - /LayoutTests w/ pixel tests disabled: 555.34s - /LayoutTests w/ pixel tests enabled: 601.47s (+8.3%) It'd be good to have data on a PPC machine as there can be minor differences in CG rendering, then we should have all the needed info to decide!
Note You need to log in before you can comment on or make changes to this bug.