RESOLVED FIXED223225
[prepare-ChangeLog] Assigning a multiline comment to a variable breaks change detection 
https://bugs.webkit.org/show_bug.cgi?id=223225
Summary [prepare-ChangeLog] Assigning a multiline comment to a variable breaks change...
Dean Johnson
Reported 2021-03-15 17:19:42 PDT
As of bug 182405 / http://trac.webkit.org/changeset/228131/webkit, prepare-ChangeLog fails to correctly detect changes to a Python file when a multiline comment is defined and assigned to a variable. Failure case: TABLE_CSS_STYLING = ''' <style> ... (Unimportant) ... </style> ''' Changing the TABLE_CSS_STYLING definition makes prepare-ChangeLog work again: TABLE_CSS_STYLING = \ ''' <style> ... (Unimportant) ... </style> ''' prepare-ChangeLog should support multiline string assignment on the same line.
Attachments
fix-multiline-string-variable-definition_v1 (2.94 KB, patch)
2021-03-15 17:37 PDT, Dean Johnson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Johnson
Comment 1 2021-03-15 17:37:01 PDT
Created attachment 423273 [details] fix-multiline-string-variable-definition_v1
EWS
Comment 2 2021-03-16 09:06:01 PDT
Committed r274481: <https://commits.webkit.org/r274481> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423273 [details].
Radar WebKit Bug Importer
Comment 3 2021-03-16 09:07:18 PDT
<rdar://problem/75479145>
Note You need to log in before you can comment on or make changes to this bug.