Bug 223225 - [prepare-ChangeLog] Assigning a multiline comment to a variable breaks change detection
Summary: [prepare-ChangeLog] Assigning a multiline comment to a variable breaks change...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Johnson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 17:19 PDT by Dean Johnson
Modified: 2021-03-16 09:07 PDT (History)
5 users (show)

See Also:

Attachments
fix-multiline-string-variable-definition_v1 (2.94 KB, patch)
2021-03-15 17:37 PDT, Dean Johnson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Johnson 2021-03-15 17:19:42 PDT 
As of bug 182405 / http://trac.webkit.org/changeset/228131/webkit, prepare-ChangeLog fails to correctly detect changes to a Python file when a multiline comment is defined and assigned to a variable.

Failure case:
TABLE_CSS_STYLING = '''
<style>
...  (Unimportant) ...
</style>
'''

Changing the TABLE_CSS_STYLING definition makes prepare-ChangeLog work again:
TABLE_CSS_STYLING = \
'''
<style>
...  (Unimportant) ...
</style>
'''

prepare-ChangeLog should support multiline string assignment on the same line.
Comment 1 Dean Johnson 2021-03-15 17:37:01 PDT 
Created attachment 423273 [details]
fix-multiline-string-variable-definition_v1
Comment 2 EWS 2021-03-16 09:06:01 PDT 
Committed r274481: <https://commits.webkit.org/r274481>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423273 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-16 09:07:18 PDT 
<rdar://problem/75479145>