Bug 223219 - [WebIDL] Optimize convertRecord() to avoid double |key| lookup
Summary: [WebIDL] Optimize convertRecord() to avoid double |key| lookup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-15 15:18 PDT by Alexey Shvayka
Modified: 2021-03-16 16:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.46 KB, patch)
2021-03-15 15:24 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Microbenchmark (639 bytes, text/html)
2021-03-16 09:47 PDT, Alexey Shvayka 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2021-03-15 15:18:38 PDT 
[WebIDL] Optimize convertRecord() to avoid double |key| lookup
Comment 1 Alexey Shvayka 2021-03-15 15:24:12 PDT 
Created attachment 423253 [details]
Patch
Comment 2 Alexey Shvayka 2021-03-16 09:47:42 PDT 
Created attachment 423342 [details]
Microbenchmark

10 keys / 10k runs / 1s interval

Trunk: 26.5ms
Patch: 21.2ms (20% faster)
Comment 3 Alexey Shvayka 2021-03-16 15:27:33 PDT 
Comment on attachment 423253 [details]
Patch

Windows EWS failures are unrelated. cq+
Comment 4 EWS 2021-03-16 16:02:29 PDT 
Committed r274529: <https://commits.webkit.org/r274529>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423253 [details].
Comment 5 Radar WebKit Bug Importer 2021-03-16 16:03:18 PDT 
<rdar://problem/75499121>