Bug 223215 – [resultsdbpy] Allow user to change commit representation

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Allow users to pick how commits are represented for a given repository.

[Radar WebKit Bug Importer]

<rdar://problem/75446602>

[Jonathan Bedard]

Created attachment 423240 [details]
Patch

Comment on attachment 423240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423240&action=review

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:150
> +        let preference = CommitBank._representationCache ? CommitBank._representationCache[this.repository_id].representation : null;

Use `const` since we are not modifying?

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js:390
> +                    });
> +                }
> +            }
> +        });

Mismatched indentation.

[Zhifei Fang]

Comment on attachment 423240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423240&action=review

> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/drawer.js:379
> +            element.onclick = () => {

We should use onStateUpdate for rendering isExpanded, without it, your update will be outside requestAnimationFrame, we should make sure all of our DOM updates inside of it.

You can do:
const expander = REF.createRef({...})；
expander.fromEvent('click').action(() => expander.setState({isExpanded: !isExpanded}));

Comment on attachment 423240 [details]
Patch

r=me

[Jonathan Bedard]

Created attachment 423392 [details]
Patch

[Jonathan Bedard]

Created attachment 423396 [details]
Patch for landing

[EWS]

Committed r274523: <https://commits.webkit.org/r274523>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423396 [details].