RESOLVED FIXED223209
Web Inspector: remove experimental setting and enable "grid" badges 
https://bugs.webkit.org/show_bug.cgi?id=223209
Summary Web Inspector: remove experimental setting and enable "grid" badges
Nikita Vasilyev
Reported 2021-03-15 12:44:11 PDT
"grid" badges are ready to be enabled by default.
Attachments
Patch (3.77 KB, patch)
2021-03-15 12:51 PDT, Nikita Vasilyev 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2021-03-16 10:02 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-03-15 12:44:20 PDT
<rdar://problem/75442185>
Nikita Vasilyev
Comment 2 2021-03-15 12:51:58 PDT
Created attachment 423225 [details] Patch
Blaze Burg
Comment 3 2021-03-15 14:00:14 PDT
Comment on attachment 423225 [details] Patch r=me but please rebase and send to EWS
Nikita Vasilyev
Comment 4 2021-03-16 09:07:37 PDT
I'm going to add a backend command check here as well.
Nikita Vasilyev
Comment 5 2021-03-16 10:00:42 PDT
(In reply to Nikita Vasilyev from comment #4) > I'm going to add a backend command check here as well. Actually, this isn't necessary. There's already check for `layoutContextType !== WI.DOMNode.LayoutContextType.Grid` that prevents showing the grid badges when the backend end is old.
Nikita Vasilyev
Comment 6 2021-03-16 10:02:14 PDT
Created attachment 423348 [details] Patch
Nikita Vasilyev
Comment 7 2021-03-17 11:26:28 PDT
Comment on attachment 423348 [details] Patch Unrelated test failure in http/tests/css/filters-on-iframes-transform.html.
EWS
Comment 8 2021-03-17 11:56:36 PDT
Committed r274575: <https://commits.webkit.org/r274575> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423348 [details].
Note You need to log in before you can comment on or make changes to this bug.