RESOLVED FIXED223203
Change canvasChanged() to take a Optional<FloatRect> 
https://bugs.webkit.org/show_bug.cgi?id=223203
Summary Change canvasChanged() to take a Optional<FloatRect>
Simon Fraser (smfr)
Reported 2021-03-15 11:40:33 PDT
Change canvasChanged() to take a Optional<FloatRect>
Attachments
Patch (15.29 KB, patch)
2021-03-15 11:45 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (16.52 KB, patch)
2021-03-15 12:14 PDT, Simon Fraser (smfr) 		sabouhallawa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-03-15 11:45:57 PDT
Created attachment 423212 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-03-15 12:14:57 PDT
Created attachment 423216 [details] Patch
Said Abou-Hallawa
Comment 3 2021-03-15 12:31:59 PDT
Comment on attachment 423216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423216&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:322 > + FloatRect backingStoreBounds() const { return FloatRect { { }, FloatSize { canvasBase().size() } }; } I think you can omit FloatRect and FloatSize.
Chris Dumez
Comment 4 2021-03-15 12:49:13 PDT
Comment on attachment 423216 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423216&action=review > Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:152 > +void CanvasCaptureMediaStreamTrack::Source::canvasChanged(CanvasBase& canvas, Optional<FloatRect>) Why are we no longer passing is as a const ref? If anything, the object is larger now...
Simon Fraser (smfr)
Comment 5 2021-03-15 13:49:38 PDT
Changed to const Optional<FloatRect>& https://trac.webkit.org/changeset/274436/webkit
Radar WebKit Bug Importer
Comment 6 2021-03-15 13:50:16 PDT
<rdar://problem/75445274>
Note You need to log in before you can comment on or make changes to this bug.