Bug 223179 - Move instanced drawing functionality from ExtensionsGL to GraphicsContextGL
Summary: Move instanced drawing functionality from ExtensionsGL to GraphicsContextGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 223633
Blocks: gcgranglecleanup
  Show dependency tree / graph
 
Reported: 2021-03-15 05:44 PDT by Kimmo Kinnunen
Modified: 2021-03-23 05:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (12.71 KB, patch)
2021-03-22 04:41 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-03-15 05:44:23 PDT 
Move instanced drawing functionality from ExtensionsGL to GraphicsContextGL

ExtensionsGL never fulfilled its purpose. Currently it is equivalent to corresponding GraphicsContextGL instance. This just complicates the implementation.
Comment 1 Kimmo Kinnunen 2021-03-22 04:41:02 PDT 
Created attachment 423871 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-03-22 05:45:13 PDT 
<rdar://problem/75687036>
Comment 3 Kenneth Russell 2021-03-22 16:09:41 PDT 
Comment on attachment 423871 [details]
Patch

Looks good to delete this unused code. r+
Comment 4 EWS 2021-03-23 01:42:17 PDT 
commit-queue failed to commit attachment 423871 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 EWS 2021-03-23 03:57:20 PDT 
Committed r274860: <https://commits.webkit.org/r274860>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423871 [details].
Comment 6 Philippe Normand 2021-03-23 05:12:29 PDT 
This broke the WPE build...
Comment 7 Kimmo Kinnunen 2021-03-23 05:16:26 PDT 
(In reply to Philippe Normand from comment #6)
> This broke the WPE build...

Sorry. I'll check.
Comment 8 Philippe Normand 2021-03-23 05:20:12 PDT 
This is what I have so far: http://sprunge.us/ZTnlLR
Comment 9 Philippe Normand 2021-03-23 05:32:54 PDT 
(In reply to Philippe Normand from comment #8)
> This is what I have so far: http://sprunge.us/ZTnlLR

Not good :)
Comment 10 Kimmo Kinnunen 2021-03-23 05:34:06 PDT 
tracked in bug 223633