Bug 223171 - [GLIB] Filter cppfilt output when generating crash logs
Summary: [GLIB] Filter cppfilt output when generating crash logs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-14 22:14 PDT by Lauro Moura
Modified: 2021-05-04 06:12 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.68 KB, patch)
2021-03-14 22:15 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-03-14 22:14:25 PDT
[GLIB] Filter cppfilt output when generating crash logs
Comment 1 Lauro Moura 2021-03-14 22:15:00 PDT
Created attachment 423143 [details]
Patch
Comment 2 EWS 2021-03-15 06:15:47 PDT
Committed r274418: <https://commits.webkit.org/r274418>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423143 [details].
Comment 3 Radar WebKit Bug Importer 2021-03-15 06:16:21 PDT
<rdar://problem/75427328>
Comment 4 Philippe Normand 2021-05-04 06:12:52 PDT
I'm getting unicode errors, I suspect it might be related with this patch...

                                                                           
worker/22: UnicodeDecodeError(''ascii' codec can't decode byte 0xe5 in position 15814: ordinal not in range(128)') raised:                                                                  
    File "/app/webkit/Tools/Scripts/webkitpy/common/message_pool.py", line 279, in run
      worker.handle(message.name, message.src, *message.args)
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 286, in handle
      self._run_test(test_input, test_list_name)
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 302, in _run_test
      result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done)
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 368, in _run_test_with_or_without_timeout
      return self._run_test_in_this_thread(test_input, stop_when_done)
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 454, in _run_test_in_this_thread
      return self._run_single_test(self._driver, test_input, stop_when_done)
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 458, in _run_single_test
      self._name, driver, test_input, stop_when_done)
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 46, in run_single_test
      return runner.run()
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 105, in run
      return self._run_compare_test()
    File "/app/webkit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 108, in _run_compare_test
      driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done)
    File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 818, in run_test
      return self._driver.run_test(driver_input, stop_when_done)
    File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 241, in run_test
      self.error_from_test, crash_log = self._get_crash_log(text, self.error_from_test, newer_than=start_time)
    File "/app/webkit/Tools/Scripts/webkitpy/port/driver.py", line 310, in _get_crash_log
      return self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, stdout, stderr, newer_than, target_host=self._target_host)
    File "/app/webkit/Tools/Scripts/webkitpy/port/gtk.py", line 247, in _get_crash_log
      self._filesystem, self._path_to_driver, self.port_name, self.get_option('configuration')).generate_crash_log(stdout, stderr)
    File "/app/webkit/Tools/Scripts/webkitpy/port/linux_get_crash_log.py", line 183, in generate_crash_log
      %(errors_str)s""" % locals())