Bug 223168 – Add internal additions for WebAuthn compatibility

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Kate Cheney]

com.apple.webkit.webauthn should actually be com.apple.WebKit.WebAuthn for internal-compatibility reasons.

[Kate Cheney]

<rdar://problem/74890060>

[Kate Cheney]

Created attachment 423137 [details]
Patch

[Brent Fulgham]

Comment on attachment 423137 [details]
Patch

Case sensitivity. *sigh*. r=me

[Jiewen Tan]

Comment on attachment 423137 [details]
Patch

Can we just add the WKA part and remove the entitlement part?

[Kate Cheney]

Created attachment 423224 [details]
Patch

[Kate Cheney]

(In reply to Jiewen Tan from comment #4)
> Comment on attachment 423137 [details]
> Patch
> 
> Can we just add the WKA part and remove the entitlement part?

Yes, I updated the patch.

[Jiewen Tan]

Comment on attachment 423224 [details]
Patch

LGTM.

[Kate Cheney]

Created attachment 423255 [details]
Patch

[Brent Fulgham]

Comment on attachment 423255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423255&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:54
> +static NSDictionary *createAlternateQuery(const String&) { return [NSDictionary alloc]; }

Could this just be return nil, or perhapss ASSERT_NOT_REACHED? I don't think we should ever hit this code path.

[Chris Dumez]

Comment on attachment 423255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423255&action=review

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:54
>> +static NSDictionary *createAlternateQuery(const String&) { return [NSDictionary alloc]; }
> 
> Could this just be return nil, or perhapss ASSERT_NOT_REACHED? I don't think we should ever hit this code path.

Please don't call [NSDictionary alloc] here, this would leak.

[Chris Dumez]

Comment on attachment 423255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423255&action=review

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:142
> +        query = createAlternateQuery(rpId);

Based on how this is used, createAlternateQuery() seems to either leak or return an autoreleased value. If it returns an autoreleased value, then I think we should not use "create" in the name. If it returns a value that is not autoreleased, then I think createAlternateQuery() should return a RetainPtr<>.

[Kate Cheney]

Created attachment 423292 [details]
Patch

[Brent Fulgham]

Comment on attachment 423292 [details]
Patch

r=me

[EWS]

Committed r274490: <https://commits.webkit.org/r274490>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423292 [details].