Bug 223158 – [JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to PDT

• Status: REOPENED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to DST

[Yusuke Suzuki]

Created attachment 423120 [details]
Patch

[Mark Lam]

Comment on attachment 423120 [details]
Patch

r=me

Thanks for fixing this.  This bug has been present going back at least 8 years.  For 2 hours a year when we switch daylight savings time, this test would always fail.

I see that the real change that matters is that you specified "TZ=PST" and use runComplexTest to get it applied to the environment.  However, I wasn't able to tease out where our system picks up this env var.  Would you mind pointing me to it for future reference?

[Yusuke Suzuki]

(In reply to Mark Lam from comment #2)
> Comment on attachment 423120 [details]
> Patch
> 
> r=me
> 
> Thanks for fixing this.  This bug has been present going back at least 8
> years.  For 2 hours a year when we switch daylight savings time, this test
> would always fail.
> 
> I see that the real change that matters is that you specified "TZ=PST" and
> use runComplexTest to get it applied to the environment.  However, I wasn't
> able to tease out where our system picks up this env var.  Would you mind
> pointing me to it for future reference?

This is ICU. "TZ" environment variable is recognized by ICU, and we use it for ICU date times. And JSC's date implementation is using ICU.

[Yusuke Suzuki]

Committed r274405 (235272@main): <https://commits.webkit.org/235272@main>

[Radar WebKit Bug Importer]

<rdar://problem/75412033>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 223187