Bug 223134 - REGRESSION (r274308): Two assertions in JSGlobalObject::defineOwnProperty() are failing
Summary: REGRESSION (r274308): Two assertions in JSGlobalObject::defineOwnProperty() a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-12 12:48 PST by WebKit Commit Bot
Modified: 2021-03-14 15:20 PDT (History)
11 users (show)

See Also:


Attachments
REVERT of r274308 (40.73 KB, patch)
2021-03-12 12:48 PST, WebKit Commit Bot
no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2021-03-12 14:36 PST, Alexey Shvayka
ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2021-03-12 12:48:07 PST
https://trac.webkit.org/changeset/274308 broke the build:
Caused assertion failure with JSC tests

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2021-03-12 12:48:18 PST
Created attachment 423074 [details]
REVERT of r274308

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2021-03-12 12:52:06 PST
commit-queue failed to commit attachment 423074 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 3 Alexey Shvayka 2021-03-12 14:36:56 PST
Created attachment 423084 [details]
Patch
Comment 4 Yusuke Suzuki 2021-03-13 17:59:58 PST
Comment on attachment 423084 [details]
Patch

r=me
Comment 5 Alexey Shvayka 2021-03-14 15:18:48 PDT
Committed r274406 (235273@main): <https://commits.webkit.org/235273@main>
Comment 6 Radar WebKit Bug Importer 2021-03-14 15:19:14 PDT
<rdar://problem/75412061>
Comment 7 Alexey Shvayka 2021-03-14 15:20:17 PDT
(In reply to Yusuke Suzuki from comment #4)
> Comment on attachment 423084 [details]
> Patch
> 
> r=me

Thanks!