Bug 223121 – Simulated WebGL context screen change events should work with GPU process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kimmo Kinnunen]

Simulated WebGL context screen change events should work with GPU process

Bug 219669 tried to fix it, but did not succeed

fails:
     fast/canvas/webgl/webglcontextchangedevent.html

[Kimmo Kinnunen]

Created attachment 423048 [details]
Patch

[Kimmo Kinnunen]

Created attachment 423060 [details]
Patch

[Kimmo Kinnunen]

Created attachment 423067 [details]
Patch

[Darin Adler]

Comment on attachment 423067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423067&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h:118
> +#if ENABLE(WEBGL)
> +    void dispatchDisplayWasReconfiguredForTesting() { dispatchDisplayWasReconfigured(); };
> +#endif

Style-wise, a while back we found that using boolean expressions and separate #if was clearer, and easier to keep correct when refactoring than nested #if. So this would be nice as:

#endif
#if PLATFORM(MAC) && ENABLE(WEBGL)
    // ...
#endif

Please consider that form. I’d suggest that above in the .cpp file too for the same reason.

> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:281
> +        callOnMainRunLoop([gpuConnectionToWebProcess = m_gpuConnectionToWebProcess]() {
> +            if (auto connectionToWeb = gpuConnectionToWebProcess.get())
> +                connectionToWeb->dispatchDisplayWasReconfiguredForTesting();
> +        });

You don’t have to take my suggestions, but I think the best names for these two would be: weakConnection (the capture) and connection (the local).

[Kimmo Kinnunen]

Created attachment 423152 [details]
Patch

[EWS]

Committed r274412: <https://commits.webkit.org/r274412>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423152 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75425294>