RESOLVED FIXED 22312
Fix PCRE include path problem on Qt-port 
https://bugs.webkit.org/show_bug.cgi?id=22312
Summary Fix PCRE include path problem on Qt-port
Gabor Loki
Reported 2008-11-17 08:28:06 PST
The pcre.pri contains wrong include path. The 'INCLUDEPATH += $$PWD $$OUTPUT_DIR/JavaScriptCore/parser/tmp' line should be 'INCLUDEPATH += $$PWD $$OUTPUT_DIR/JavaScriptCore/tmp'. No one creates 'parser' directory.
Attachments
Proposed patch (949 bytes, patch)
2008-11-17 08:29 PST, Gabor Loki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Loki
Comment 1 2008-11-17 08:29:31 PST
Created attachment 25216 [details] Proposed patch
Darin Adler
Comment 2 2008-11-17 09:16:03 PST
Comment on attachment 25216 [details] Proposed patch > diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > index 13e79c0..fbc2cea 100644 > --- a/JavaScriptCore/ChangeLog > +++ b/JavaScriptCore/ChangeLog > @@ -1,3 +1,13 @@ > +2008-11-17 Gabor Loki <loki@inf.u-szeged.hu> > + > + Reviewed by NOBODY (OOPS!). > + > + <https://bugs.webkit.org/show_bug.cgi?id=22312> > + Fix PCRE include path problem on Qt-port Please don't put tabs in anything, including ChangeLog entries. This makes extra work for the committers, who has to change them into spaces. > + * JavaScriptCore.pri: This file is in the ChangeLog, but not changed in the patch. r=me
Geoffrey Garen
Comment 3 2008-11-17 09:36:56 PST
Committed revision 38508.
Gabor Loki
Comment 4 2008-11-17 11:55:37 PST
Opps. Sorry, I missed them. At first I wanted to send this and bug #22313 together, but I changed my mind and accidentally left those in the ChangeLog.
Note You need to log in before you can comment on or make changes to this bug.