Bug 22312 - Fix PCRE include path problem on Qt-port
Summary: Fix PCRE include path problem on Qt-port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-17 08:28 PST by Gabor Loki
Modified: 2008-11-17 11:55 PST (History)
0 users

See Also:


Attachments
Proposed patch (949 bytes, patch)
2008-11-17 08:29 PST, Gabor Loki
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2008-11-17 08:28:06 PST
The pcre.pri contains wrong include path.

The 'INCLUDEPATH += $$PWD $$OUTPUT_DIR/JavaScriptCore/parser/tmp' line should be 'INCLUDEPATH += $$PWD $$OUTPUT_DIR/JavaScriptCore/tmp'.

No one creates 'parser' directory.
Comment 1 Gabor Loki 2008-11-17 08:29:31 PST
Created attachment 25216 [details]
Proposed patch
Comment 2 Darin Adler 2008-11-17 09:16:03 PST
Comment on attachment 25216 [details]
Proposed patch

> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> index 13e79c0..fbc2cea 100644
> --- a/JavaScriptCore/ChangeLog
> +++ b/JavaScriptCore/ChangeLog
> @@ -1,3 +1,13 @@
> +2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	<https://bugs.webkit.org/show_bug.cgi?id=22312>
> +	Fix PCRE include path problem on Qt-port

Please don't put tabs in anything, including ChangeLog entries. This makes extra work for the committers, who has to change them into spaces.

> +        * JavaScriptCore.pri:

This file is in the ChangeLog, but not changed in the patch.

r=me
Comment 3 Geoffrey Garen 2008-11-17 09:36:56 PST
Committed revision 38508.

Comment 4 Gabor Loki 2008-11-17 11:55:37 PST
Opps. Sorry, I missed them.
At first I wanted to send this and bug #22313 together, but I changed my mind and accidentally left those in the ChangeLog.