Make WebGL conformance test update script more usable and consistent
- There's two old scripts: Tools/Scripts/update-webgl-conformance-tests, LayoutTests/webgl/generate-webgl-tests
- generate-webgl-tests cannot be used to update the "sdk" tests
- generate-webgl-tests needs manual flags, it is hard to know what the previous person used
Created attachment 423020 [details]
Created attachment 423021 [details]
James (jdarpinian@), could you help review this?
Kimmo, I'll mark this r+ assuming it's been tested but please wait for James' review. Thanks.
Comment on attachment 423021 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=423021&action=review
> + - to copy the "beta" 1.0.3/2.0.0 tests for the features that are implemented
As long as we're regenerating everything, what do you think about taking the opportunity to upgrade to 1.0.4/2.0.1, which includes all these tests automatically? Then we won't need extra special tests off to the side. Chrome and Firefox both test against 1.0.4/2.0.1 currently.
(In reply to James Darpinian from comment #4)
> As long as we're regenerating everything, what do you think about taking the
> opportunity to upgrade to 1.0.4/2.0.1, which includes all these tests
> automatically? Then we won't need extra special tests off to the side.
> Chrome and Firefox both test against 1.0.4/2.0.1 currently.
So what's the definition of 1.0.4/2.0.1 ? I.e where are they?
(In reply to Kimmo Kinnunen from comment #5)
> So what's the definition of 1.0.4/2.0.1 ? I.e where are they?
So is it:
copying WebGL/sdk/tests -> resources/webgl_conformance_tests
generating drivers to 1.0.4/ with suite version 1.0.4
generating drivers to 2.0.1/ with suite version 2.0.1
Maybe I'll try that.
Yes, 1.0.4/2.0.1 haven't been snapshotted yet. They are just the tests in WebGL/sdk/tests.
Created attachment 423379 [details]
Comment on attachment 423379 [details]
Awesome, thank you! It will be great to have the most up to date version of all the tests on the bots. Ken will have to set r+ as I am not a reviewer.
Committed r274518: <https://commits.webkit.org/r274518>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 423379 [details].