Bug 223112 - Make WebGL conformance test update script more usable and consistent
Summary: Make WebGL conformance test update script more usable and consistent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: webgl2conformance
  Show dependency tree / graph
 
Reported: 2021-03-12 00:30 PST by Kimmo Kinnunen
Modified: 2021-03-16 14:28 PDT (History)
11 users (show)

See Also:

Attachments
Patch (43.98 KB, patch)
2021-03-12 00:42 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (43.94 KB, patch)
2021-03-12 00:43 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (42.95 KB, patch)
2021-03-16 12:21 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-03-12 00:30:51 PST 
Make WebGL conformance test update script more usable and consistent

- There's two old scripts: Tools/Scripts/update-webgl-conformance-tests, LayoutTests/webgl/generate-webgl-tests
- generate-webgl-tests cannot be used to update the "sdk" tests
- generate-webgl-tests needs manual flags, it is hard to know what the previous person used
Comment 1 Kimmo Kinnunen 2021-03-12 00:42:42 PST 
Created attachment 423020 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-03-12 00:43:39 PST 
Created attachment 423021 [details]
Patch
Comment 3 Kenneth Russell 2021-03-12 16:43:11 PST 
James (jdarpinian@), could you help review this?

Kimmo, I'll mark this r+ assuming it's been tested but please wait for James' review. Thanks.
Comment 4 James Darpinian 2021-03-15 11:20:05 PDT 
Comment on attachment 423021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423021&action=review

LGTM!

> Tools/ChangeLog:13
> +          - to copy the "beta" 1.0.3/2.0.0 tests for the features that are implemented

As long as we're regenerating everything, what do you think about taking the opportunity to upgrade to 1.0.4/2.0.1, which includes all these tests automatically? Then we won't need extra special tests off to the side. Chrome and Firefox both test against 1.0.4/2.0.1 currently.
Comment 5 Kimmo Kinnunen 2021-03-15 12:18:55 PDT 
(In reply to James Darpinian from comment #4)
> As long as we're regenerating everything, what do you think about taking the
> opportunity to upgrade to 1.0.4/2.0.1, which includes all these tests
> automatically? Then we won't need extra special tests off to the side.
> Chrome and Firefox both test against 1.0.4/2.0.1 currently.

So what's the definition of 1.0.4/2.0.1 ? I.e where are they?
Comment 6 Kimmo Kinnunen 2021-03-15 12:59:42 PDT 
(In reply to Kimmo Kinnunen from comment #5)
> So what's the definition of 1.0.4/2.0.1 ? I.e where are they?

So is it:
 copying WebGL/sdk/tests -> resources/webgl_conformance_tests 
 generating drivers to 1.0.4/ with suite version 1.0.4
 generating drivers to 2.0.1/ with suite version 2.0.1

Maybe I'll try that.
Comment 7 James Darpinian 2021-03-15 13:12:57 PDT 
Yes, 1.0.4/2.0.1 haven't been snapshotted yet. They are just the tests in WebGL/sdk/tests.
Comment 8 Kimmo Kinnunen 2021-03-16 12:21:55 PDT 
Created attachment 423379 [details]
Patch
Comment 9 James Darpinian 2021-03-16 12:59:39 PDT 
Comment on attachment 423379 [details]
Patch

Awesome, thank you! It will be great to have the most up to date version of all the tests on the bots. Ken will have to set r+ as I am not a reviewer.
Comment 10 EWS 2021-03-16 14:27:55 PDT 
Committed r274518: <https://commits.webkit.org/r274518>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 423379 [details].
Comment 11 Radar WebKit Bug Importer 2021-03-16 14:28:25 PDT 
<rdar://problem/75494562>