Bug 223111 – Fix interpolation of perspective property

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Fix interpolation of perspective property

[Antoine Quint]

Created attachment 423018 [details]
Patch

[Antti Koivisto]

Comment on attachment 423018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423018&action=review

> Source/WebCore/rendering/style/RenderStyle.h:719
> +    bool hasPerspective() const { return m_rareNonInheritedData->perspective != -1; }

Maybe this could compare against initialPerspective() instead of -1 to be less magical.

> Source/WebCore/style/StyleBuilderConverter.h:1229
> -        return 0.f;
> +        return -1;

Similarly this could return RenderStyle::initialPerspective().

[Antoine Quint]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 423018 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=423018&action=review
> 
> > Source/WebCore/rendering/style/RenderStyle.h:719
> > +    bool hasPerspective() const { return m_rareNonInheritedData->perspective != -1; }
> 
> Maybe this could compare against initialPerspective() instead of -1 to be
> less magical.
> 
> > Source/WebCore/style/StyleBuilderConverter.h:1229
> > -        return 0.f;
> > +        return -1;
> 
> Similarly this could return RenderStyle::initialPerspective().

Yes, good points. Even though the initial value could be something other than "none", it's unlikely to change and it'd be more explicit than -1.

[Antoine Quint]

Committed r274329 (235217@main): <https://commits.webkit.org/235217@main>

[Radar WebKit Bug Importer]

<rdar://problem/75353982>