Commits should be saved with identifiers, hashes and revisions.
<rdar://problem/75338338>
Created attachment 422989 [details] Patch
Created attachment 423085 [details] Patch
Comment on attachment 423085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423085&action=review > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/commit_context.py:390 > + ('identifier', lambda commit: str(commit)), This can be just `str`
Created attachment 423262 [details] Patch
Comment on attachment 423262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423262&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:156 > + print('{} vs {}'.format(hash_from_id, revision_from_id)) Do we expect this print here?
Comment on attachment 423262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423262&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:156 >> + print('{} vs {}'.format(hash_from_id, revision_from_id)) > > Do we expect this print here? No, I also broke this change out into an independent one: https://bugs.webkit.org/show_bug.cgi?id=223224 (although tests will fail without it, so the independent one needs to land first)
Created attachment 423346 [details] Patch
r=me
Created attachment 423414 [details] Patch
Committed r274542: <https://commits.webkit.org/r274542> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423414 [details].