Bug 223092 - Use BinarySemaphore in callOnMainAndWait()
Summary: Use BinarySemaphore in callOnMainAndWait()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-11 14:23 PST by Chris Dumez
Modified: 2021-03-11 18:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.22 KB, patch)
2021-03-11 14:25 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-03-11 14:23:34 PST 
Use BinarySemaphore in callOnMainAndWait() instead of a Condition, this simplifies the code a bit.
Comment 1 Chris Dumez 2021-03-11 14:25:24 PST 
Created attachment 422971 [details]
Patch
Comment 2 Geoffrey Garen 2021-03-11 14:27:15 PST 
Comment on attachment 422971 [details]
Patch

r=me
Comment 3 EWS 2021-03-11 15:16:08 PST 
commit-queue failed to commit attachment 422971 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 4 EWS 2021-03-11 15:21:32 PST 
commit-queue failed to commit attachment 422971 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 EWS 2021-03-11 15:52:26 PST 
commit-queue failed to commit attachment 422971 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 6 Chris Dumez 2021-03-11 15:54:23 PST 
Comment on attachment 422971 [details]
Patch

Clearing flags on attachment: 422971

Committed r274304 (235198@main): <https://commits.webkit.org/235198@main>
Comment 7 Chris Dumez 2021-03-11 15:54:26 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2021-03-11 15:55:16 PST 
<rdar://problem/75337063>
Comment 9 Yusuke Suzuki 2021-03-11 18:39:59 PST 
I'm happy to see that BinarySemaphore is used to clean up these things!