Bug 223091 - [macOS] override the background color of PDF documents to match PDFKit
Summary: [macOS] override the background color of PDF documents to match PDFKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-11 14:17 PST by Devin Rousso
Modified: 2021-03-11 16:22 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2021-03-11 14:23 PST, Devin Rousso
thorton: review+
Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2021-03-11 15:20 PST, Devin Rousso
hi: commit-queue+
Details | Formatted Diff | Diff
Patch (2.45 KB, patch)
2021-03-11 15:21 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-11 14:17:08 PST
.
Comment 1 Devin Rousso 2021-03-11 14:18:03 PST
<rdar://problem/74584770>
Comment 2 Devin Rousso 2021-03-11 14:23:14 PST
Created attachment 422969 [details]
Patch
Comment 3 Tim Horton 2021-03-11 14:26:01 PST
Comment on attachment 422969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422969&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:621
> +        // FIXME: <rdar://problem/75332948>

This should say what it's about, because many WebKit contributors can't read the radar.
Comment 4 Devin Rousso 2021-03-11 15:20:34 PST
Created attachment 422980 [details]
Patch
Comment 5 Devin Rousso 2021-03-11 15:21:20 PST
Created attachment 422982 [details]
Patch
Comment 6 EWS 2021-03-11 15:48:31 PST
commit-queue failed to commit attachment 422982 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 7 EWS 2021-03-11 16:22:13 PST
Committed r274310: <https://commits.webkit.org/r274310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422982 [details].