RESOLVED FIXED 223078
[macCatalyst] media controls should have macOS styling and behavior 
https://bugs.webkit.org/show_bug.cgi?id=223078
Summary [macCatalyst] media controls should have macOS styling and behavior
Devin Rousso
Reported 2021-03-11 10:33:20 PST
.
Attachments
Patch (170.11 KB, patch)
2021-03-11 11:02 PST, Devin Rousso 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (170.11 KB, patch)
2021-03-11 13:07 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-03-11 10:33:34 PST
<rdar://problem/71857091>
Devin Rousso
Comment 2 2021-03-11 11:02:06 PST
Created attachment 422946 [details] Patch
Eric Carlson
Comment 3 2021-03-11 11:18:24 PST
Comment on attachment 422946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review > Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117 > + return nullString(); ASSERT_NOT_REACHED()?
Devin Rousso
Comment 4 2021-03-11 11:20:24 PST
Comment on attachment 422946 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review >> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117 >> + return nullString(); > > ASSERT_NOT_REACHED()? Do other platforms also use modern media controls? I wasn't sure so I left it as an unknown (which also matches the existing behavior).
Devin Rousso
Comment 5 2021-03-11 13:07:22 PST
Created attachment 422958 [details] Patch
EWS
Comment 6 2021-03-11 13:36:55 PST
Committed r274299: <https://commits.webkit.org/r274299> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422958 [details].
Note You need to log in before you can comment on or make changes to this bug.