Bug 223078 - [macCatalyst] media controls should have macOS styling and behavior
Summary: [macCatalyst] media controls should have macOS styling and behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-11 10:33 PST by Devin Rousso
Modified: 2021-03-11 13:36 PST (History)
15 users (show)

See Also:

Attachments
Patch (170.11 KB, patch)
2021-03-11 11:02 PST, Devin Rousso 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (170.11 KB, patch)
2021-03-11 13:07 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-03-11 10:33:20 PST 
.
Comment 1 Devin Rousso 2021-03-11 10:33:34 PST 
<rdar://problem/71857091>
Comment 2 Devin Rousso 2021-03-11 11:02:06 PST 
Created attachment 422946 [details]
Patch
Comment 3 Eric Carlson 2021-03-11 11:18:24 PST 
Comment on attachment 422946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117
> +    return nullString();

ASSERT_NOT_REACHED()?
Comment 4 Devin Rousso 2021-03-11 11:20:24 PST 
Comment on attachment 422946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review

>> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117
>> +    return nullString();
> 
> ASSERT_NOT_REACHED()?

Do other platforms also use modern media controls?  I wasn't sure so I left it as an unknown (which also matches the existing behavior).
Comment 5 Devin Rousso 2021-03-11 13:07:22 PST 
Created attachment 422958 [details]
Patch
Comment 6 EWS 2021-03-11 13:36:55 PST 
Committed r274299: <https://commits.webkit.org/r274299>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422958 [details].