When configuring wpewebkit 2.31.90 (with libwpe 1.9.90, wpebackend-fdo 1.9.1) with -DENABLE_WPE_QT_API=ON and then building with cmake, I stumble upon: [...] [4722/4722] Linking CXX shared library lib/libqtwpe.so FAILED: lib/libqtwpe.so /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtView Backend.cpp.o: in function `WPEQtViewBackend::create(QSizeF const&, QPointer<QOpenGLContext>, void*, QPointer<WPEQtView>)': WPEQtViewBackend.cpp:(.text+0x382): undefined reference to `WTF::fastMalloc(unsigned int)' /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtView Backend.cpp.o: in function `WPEQtViewBackend::~WPEQtViewBackend()': WPEQtViewBackend.cpp:(.text+0xeaa): undefined reference to `WTF::fastFree(void*)' /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtView.cpp.o: in function `WPEQtView::notifyLoadFailedCallback(_WebKitWebView*, WebKitLoadEvent, char const*, _GError*, WPEQtView*)': WPEQtView.cpp:(.text+0x1ce): undefined reference to `WTF::fastMalloc(unsigned int)' /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtView.cpp.o: in function `WPEQtView::notifyLoadChangedCallback(_WebKitWebView*, WebKitLoadEvent, WPEQtView*)': WPEQtView.cpp:(.text+0xbf6): undefined reference to `WTF::fastMalloc(unsigned int)' /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtView.cpp.o: in function `WPEQtView::runJavaScript(QString const&, QJSValue const&)': WPEQtView.cpp:(.text+0x100e): undefined reference to `WTF::fastMalloc(unsigned int)' /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtView.cpp.o: in function `jsAsyncReadyCallback(_GObject*, _GAsyncResult*, void*)': WPEQtView.cpp:(.text+0x12ee): undefined reference to `WTF::fastFree(void*)' /opt/OSELAS.Toolchain-2020.08.0/arm-v7a-linux-gnueabihf/gcc-10.2.1-clang-10.0.1-glibc-2.32-binutils-2.35-kernel-5.8-sanitized/lib/gcc/arm-v7a-linux-gnueabihf/10.2.1/../../../../arm-v7a-linux-gnueabihf/bin/ld: Source/WebKit/CMakeFiles/qtwpe.dir/UIProcess/API/wpe/qt/WPEQtViewLoadRequest.cpp.o: in function `WPEQtViewLoadRequest::~WPEQtViewLoadRequest()': WPEQtViewLoadRequest.cpp:(.text+0xf6): undefined reference to `WTF::fastFree(void*)' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed.
This is also broken in the latest stable wpewebkit 2.32.0.
Created attachment 426400 [details] Patch This patch reverts the WTF usage since this code has nothing to do with webkit internals at all.
Comment on attachment 426400 [details] Patch LGTM. Can you add these files in a new allow-list for the style-checker? Should be in Tools/Scripts/webkitpy/style/checker.py
Yep, I can add those files.
Created attachment 426421 [details] Patch This adds the style checker allow-list.
Comment on attachment 426421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426421&action=review > Tools/Scripts/webkitpy/style/checker.py:167 > + os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt')], I think this works only for files, not individual directories.
(In reply to Philippe Normand from comment #6) > Comment on attachment 426421 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426421&action=review > > > Tools/Scripts/webkitpy/style/checker.py:167 > > + os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt')], > > I think this works only for files, not individual directories. I've tested it and saw no more errors after applying it.
But.. My indent is wrong.. Damn
I don't see how this failures are related to my commit
Please fix the style EWS. The wincairo failure looks indeed unrelated.
(In reply to Philippe Normand from comment #10) > Please fix the style EWS. The wincairo failure looks indeed unrelated. I followed the style within the checker.py list. Don't see what I did wrong.
(In reply to Marco Felsch from comment #11) > (In reply to Philippe Normand from comment #10) > > Please fix the style EWS. The wincairo failure looks indeed unrelated. > > I followed the style within the checker.py list. Don't see what I did wrong. Me neither. This pep thing is quite pedantic. Anyway, the fix I found is to dedent all 4 lines by one space. No idea why: ([ # The WPE QT wrapper lib is not part of Webkit and therefore don't need to statically # link the WTF framwork. Instead it uses the standard alloc mechanism. os.path.join('Source', 'WebKit', 'UIProcess', 'API', 'wpe', 'qt')], ["-runtime/wtf_make_unique"]), You can run Tools/Scripts/check-webkit-style locally btw.
Comment on attachment 426421 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426421&action=review > Tools/Scripts/webkitpy/style/checker.py:166 > + # link the WTF framwork. Instead it uses the standard alloc mechanism. And fix the framwork typo while you're at it ;)
Created attachment 426535 [details] Patch Now the style is fixed :)
(In reply to Philippe Normand from comment #13) > Comment on attachment 426421 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426421&action=review > > > Tools/Scripts/webkitpy/style/checker.py:166 > > + # link the WTF framwork. Instead it uses the standard alloc mechanism. > > And fix the framwork typo while you're at it ;) Did that as well.
/Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Sorry for the noise but how is fixed that failure..
Comment on attachment 426535 [details] Patch You should have left the "Reviewed by OOPS" lines...
https://webkit.org/contributing-code/#changelog-files
Created attachment 426547 [details] Patch Hopefully the last version...
commit-queue failed to commit attachment 426547 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r276308 (236790@main): <https://commits.webkit.org/236790@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426547 [details].