Bug 223067 – [GTK] Bump API version when building with libsoup3

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Use 4.1 for soup3, since the API hasn't actually changed and keep using 5.0 for GTK4 where the API will change.

[Carlos Garcia Campos]

Created attachment 422926 [details]
Patch

[Adrian Perez]

Comment on attachment 422926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422926&action=review

> Source/cmake/OptionsGTK.cmake:221
> +    set(WEBKITGTK_API_DOC_VERSION 4.0)

We are going to need something similar for the WPE port when building
with libsoup3, but let's do it in a separate patch.

[Carlos Garcia Campos]

Committed r274330 (235218@main): <https://commits.webkit.org/235218@main>

[Philippe Normand]

Comment on attachment 422926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422926&action=review

> Source/cmake/OptionsGTK.cmake:70
> +WEBKIT_OPTION_DEFINE(ENABLE_QUARTZ_TARGET "Whether to enable support for the Quartz windowing target." PUBLIC ON)

Why is this unconditionally enabled now?

[Carlos Garcia Campos]

Comment on attachment 422926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422926&action=review

>> Source/cmake/OptionsGTK.cmake:70
>> +WEBKIT_OPTION_DEFINE(ENABLE_QUARTZ_TARGET "Whether to enable support for the Quartz windowing target." PUBLIC ON)
> 
> Why is this unconditionally enabled now?

Because we don't have GTK_SUPPORTS_QUARTZ yet here. The GTK4 was wrong, we can't use build variables before WEBKIT_OPTION_END(). So I moved the find_package for GTK after that to check what gtk version to check for. So, targets options and enabled by default, but disabled below if GTK doesn't support them.