Bug 223035 - [iOS] Add additional telemetry to WebContent sandbox
Summary: [iOS] Add additional telemetry to WebContent sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-10 12:07 PST by Per Arne Vollan
Modified: 2021-03-10 13:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.60 KB, patch)
2021-03-10 12:13 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2021-03-10 12:35 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2021-03-10 12:36 PST, Per Arne Vollan 		ggaren: review+
Details | Formatted Diff | Diff
Patch (7.41 KB, patch)
2021-03-10 12:53 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-03-10 12:07:29 PST 
Add additional telemetry to WebContent sandbox on iOS.
Comment 1 Per Arne Vollan 2021-03-10 12:08:01 PST 
<rdar://75275161>
Comment 2 Per Arne Vollan 2021-03-10 12:13:52 PST 
Created attachment 422853 [details]
Patch
Comment 3 Per Arne Vollan 2021-03-10 12:35:49 PST 
Created attachment 422857 [details]
Patch
Comment 4 Per Arne Vollan 2021-03-10 12:36:58 PST 
Created attachment 422859 [details]
Patch
Comment 5 Geoffrey Garen 2021-03-10 12:38:02 PST 
Comment on attachment 422859 [details]
Patch

r=me

Can you remove the "XXX" comments before landing? I find bug reports in code to be distracting; and I think a bug report is a better way to track future work. If any of these comments warrant a bug report, let's file it. (It seems like the task to deny access if telemetry says that's OK probably warrants a bug report. I'm not sure that the rest do.)
Comment 6 Per Arne Vollan 2021-03-10 12:48:23 PST 
(In reply to Geoffrey Garen from comment #5)
> Comment on attachment 422859 [details]
> Patch
> 
> r=me
> 
> Can you remove the "XXX" comments before landing? I find bug reports in code
> to be distracting; and I think a bug report is a better way to track future
> work. If any of these comments warrant a bug report, let's file it. (It
> seems like the task to deny access if telemetry says that's OK probably
> warrants a bug report. I'm not sure that the rest do.)

Will do, thanks for reviewing!
Comment 7 Per Arne Vollan 2021-03-10 12:53:36 PST 
Created attachment 422862 [details]
Patch
Comment 8 Per Arne Vollan 2021-03-10 13:09:05 PST 
Landed <https://trac.webkit.org/changeset/274231/webkit>.