Bug 223027 - Improve font-variation-settings interpolation
Summary: Improve font-variation-settings interpolation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-10 06:03 PST by Antoine Quint
Modified: 2021-03-10 14:14 PST (History)
5 users (show)

See Also:

Attachments
Patch (74.37 KB, patch)
2021-03-10 06:08 PST, Antoine Quint 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (79.39 KB, patch)
2021-03-10 07:49 PST, Antoine Quint 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-03-10 06:03:59 PST 
Improve font-variation-settings interpolation
Comment 1 Antoine Quint 2021-03-10 06:08:38 PST 
Created attachment 422823 [details]
Patch
Comment 2 Antoine Quint 2021-03-10 07:49:16 PST 
Created attachment 422833 [details]
Patch
Comment 3 Dean Jackson 2021-03-10 13:29:57 PST 
Comment on attachment 422833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422833&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:535
> +    ASSERT(from.size() == to.size());

Even though you check the sizes in canInterpolate, it might be better to keep the return of the empty FontVariationSettings just in case.
Comment 4 EWS 2021-03-10 13:37:16 PST 
commit-queue failed to commit attachment 422833 [details] to WebKit repository. To retry, please set cq+ flag again.
Comment 5 Antoine Quint 2021-03-10 13:41:41 PST 
Committed r274235 (235146@main): <https://commits.webkit.org/235146@main>
Comment 6 Radar WebKit Bug Importer 2021-03-10 13:42:16 PST 
<rdar://problem/75280129>
Comment 7 Antoine Quint 2021-03-10 14:14:31 PST 
(In reply to Dean Jackson from comment #3)
> Comment on attachment 422833 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422833&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:535
> > +    ASSERT(from.size() == to.size());
> 
> Even though you check the sizes in canInterpolate, it might be better to
> keep the return of the empty FontVariationSettings just in case.

I opted to keep the ASSERT as we really shouldn't be entering this function if we don't know how to blend.