Bug 223027 – Improve font-variation-settings interpolation

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Improve font-variation-settings interpolation

[Antoine Quint]

Created attachment 422823 [details]
Patch

[Antoine Quint]

Created attachment 422833 [details]
Patch

[Dean Jackson]

Comment on attachment 422833 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422833&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:535
> +    ASSERT(from.size() == to.size());

Even though you check the sizes in canInterpolate, it might be better to keep the return of the empty FontVariationSettings just in case.

[EWS]

commit-queue failed to commit attachment 422833 [details] to WebKit repository. To retry, please set cq+ flag again.

[Antoine Quint]

Committed r274235 (235146@main): <https://commits.webkit.org/235146@main>

[Radar WebKit Bug Importer]

<rdar://problem/75280129>

[Antoine Quint]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 422833 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422833&action=review
> 
> > Source/WebCore/animation/CSSPropertyAnimation.cpp:535
> > +    ASSERT(from.size() == to.size());
> 
> Even though you check the sizes in canInterpolate, it might be better to
> keep the return of the empty FontVariationSettings just in case.

I opted to keep the ASSERT as we really shouldn't be entering this function if we don't know how to blend.