Bug 223011 – [build.webkit.org] Update RunJavaScriptCoreTests step for new buildbot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We have upgraded build.webkit.org to latest Buildbot. We should update RunJavaScriptCoreTests as per new Buildbot, e.g.: use logobserver instead of cmd.logs['stdio'].getText()

[Aakash Jain]

Created attachment 422785 [details]
Patch

Comment on attachment 422785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review

> Tools/CISupport/build-webkit-org/steps.py:437
> +        self.failedTestCount = 0

Is this used anywhere in this change?

[Aakash Jain]

Comment on attachment 422785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review

>> Tools/CISupport/build-webkit-org/steps.py:437
>> +        self.failedTestCount = 0
> 
> Is this used anywhere in this change?

It is used by the base class TestWithFailureCount (inside getResultSummary())

Comment on attachment 422785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review

>>> Tools/CISupport/build-webkit-org/steps.py:437
>>> +        self.failedTestCount = 0
>> 
>> Is this used anywhere in this change?
> 
> It is used by the base class TestWithFailureCount (inside getResultSummary())

Why was it working before this change?  By checking the code, it looks like it will be set by `TestWithFailureCount.commandComplete`.
Anyway, initialize an variable in the here seems no harm.

r=me

[Aakash Jain]

Comment on attachment 422785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422785&action=review
> Why was it working before this change?
This wasn't working properly after the upgrade. logText in countFailures was empty (as deprecated cmd.logs['stdio'].getText() return empty string in new buildbot), and so custom step message wasn't being set. 

It should be set now, e.g.: '2 JSC tests failed' in https://build.webkit-dev.org/#/builders/84/builds/3

[EWS]

Committed r274209: <https://commits.webkit.org/r274209>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422785 [details].

[Radar WebKit Bug Importer]

<rdar://problem/75260591>

[Aakash Jain]

Restated buildbot to pick up this change this morning.

Seems to be working fine. e.g.: https://build.webkit.org/#/builders/102/builds/90 now says: "29 JSC tests failed", while earlier it used to say: "jscore-test (failure)"